Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prototype Pollution #781 #26

Closed
nullivex opened this issue Feb 16, 2019 · 4 comments
Closed

Prototype Pollution #781 #26

nullivex opened this issue Feb 16, 2019 · 4 comments

Comments

@nullivex
Copy link

│ Moderate      │ Prototype Pollution                                          │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Package       │ node.extend                                                  │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Patched in    │ >=1.1.7 <2.0.0 || >= 2.0.1                                   │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Dependency of │ rmdir-promise                                                │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Path          │ rmdir-promise > rmdir > node.flow > node.extend              │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ More info     │ https://npmjs.com/advisories/781   
@nullivex
Copy link
Author

My mistake, this is part of the node.flow package using an outdated node.extend. I submitted a PR against that.

@ljharb
Copy link
Member

ljharb commented Feb 16, 2019

Note the "patched in"? This is already fixed in both the v1 and v2 lines.

@ljharb
Copy link
Member

ljharb commented Feb 16, 2019

This also means that as long as any dependent is using semver, they'll get the fix automatically with no change needed.

@nullivex
Copy link
Author

@ljharb I understand, the problem is that node.flow explicitly calls an old version of node.extend where the issue is present.

This is the real source of the current complaint: dreamerslab/node.flow#4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants