Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spellcheck should ignore capitalization #261

Closed
jyn514 opened this issue Mar 30, 2022 · 2 comments
Closed

Spellcheck should ignore capitalization #261

jyn514 opened this issue Mar 30, 2022 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@jyn514
Copy link

jyn514 commented Mar 30, 2022

Describe the bug

error: spellcheck(Hunspell)
     --> rust/library/std/src/path.rs:2031
      |
 2031 |  Calling `to_string_lossy` on a `Path` with valid unicode:
      |                                                   ^^^^^^^
      | - Unicode, uni code, uni-code, or unicorn
      |
      |   Possible spelling mistake found.

It's technically right, the proper casing is "Unicode", but this seems unnecessarily pedantic.

To Reproduce

Steps to reproduce the behaviour:

  1. A file containing unicode
  2. Run cargo spellcheck ...
  3. ...

cc rust-lang/rust#74697

Expected behavior

Screenshots

Please complete the following information:

  • System:
  • Obtained:
  • Version:

Additional context

@jyn514 jyn514 added the bug Something isn't working label Mar 30, 2022
@drahnr
Copy link
Owner

drahnr commented Mar 30, 2022

If you think this is ok for your local codebase, I'd expect unicode to be added to a project specific dictionary file. Unicode after all, is the correct term.

@drahnr
Copy link
Owner

drahnr commented Apr 3, 2022

I don't think there is a systematic approach to this, other than allowing extra word's as part of a custom dictionary which is already supported. Generally disabling capitalization / casing entirely.

If you think that doesn't cover it, happy to discuss this further

@drahnr drahnr closed this as completed Apr 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants