Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nydusify: refactor check subcommand #1652

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

imeoer
Copy link
Collaborator

@imeoer imeoer commented Dec 4, 2024

  • allow either the source or target to be an OCI or nydus image;
  • improve output directory and log format;

Relevant Issue (if applicable)

If there are Issues related to this PullRequest, please list it.

Details

Please describe the details of PullRequest.

Types of changes

What types of changes does your PullRequest introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

Go over all the following points, and put an x in all the boxes that apply.

  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.

@imeoer imeoer requested a review from a team as a code owner December 4, 2024 10:01
@imeoer imeoer requested review from hsiangkao, power-more and Desiki-high and removed request for a team December 4, 2024 10:01
@imeoer imeoer force-pushed the nydusify-checker-enhance branch from 7918b55 to efe63c3 Compare December 5, 2024 09:29
@imeoer imeoer changed the title [WIP] nydusify: enhance check subcommand [WIP] nydusify: refactor check subcommand Dec 5, 2024
@imeoer imeoer changed the title [WIP] nydusify: refactor check subcommand nydusify: refactor check subcommand Dec 5, 2024
@imeoer imeoer force-pushed the nydusify-checker-enhance branch 2 times, most recently from 62a9ca5 to a09f536 Compare December 5, 2024 10:11
Copy link

codecov bot commented Dec 5, 2024

Codecov Report

Attention: Patch coverage is 15.38462% with 242 lines in your changes missing coverage. Please review.

Project coverage is 59.95%. Comparing base (375f55f) to head (a09f536).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
contrib/nydusify/pkg/checker/rule/filesystem.go 0.00% 150 Missing ⚠️
contrib/nydusify/pkg/utils/utils.go 0.00% 30 Missing ⚠️
contrib/nydusify/pkg/checker/rule/bootstrap.go 0.00% 25 Missing ⚠️
contrib/nydusify/pkg/checker/rule/manifest.go 67.69% 13 Missing and 8 partials ⚠️
contrib/nydusify/cmd/nydusify.go 0.00% 16 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1652      +/-   ##
==========================================
- Coverage   60.10%   59.95%   -0.16%     
==========================================
  Files         147      147              
  Lines       49513    49640     +127     
  Branches    46994    46994              
==========================================
- Hits        29762    29760       -2     
- Misses      17970    18094     +124     
- Partials     1781     1786       +5     
Files with missing lines Coverage Δ
contrib/nydusify/cmd/nydusify.go 13.89% <0.00%> (-0.17%) ⬇️
contrib/nydusify/pkg/checker/rule/manifest.go 69.87% <67.69%> (-14.18%) ⬇️
contrib/nydusify/pkg/checker/rule/bootstrap.go 0.00% <0.00%> (ø)
contrib/nydusify/pkg/utils/utils.go 58.38% <0.00%> (-14.72%) ⬇️
contrib/nydusify/pkg/checker/rule/filesystem.go 0.00% <0.00%> (ø)

... and 2 files with indirect coverage changes

- allow either the source or target to be an OCI or nydus image;
- improve output directory structure and log format;

Signed-off-by: Yan Song <[email protected]>
@imeoer imeoer force-pushed the nydusify-checker-enhance branch from a09f536 to d294237 Compare December 11, 2024 01:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant