storage: fix chunk map compatibility #1417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imeoer
requested review from
luodw,
gaius-qi and
changweige
and removed request for
a team
The blob cache file of nydusd v2.2 and <=v2.1 are in different formats, which are not compatible. Should use different chunk map files for them, in order to upgrade or downgrade smoothly. For the nydusd <=v2.1, the files in blob cache directory: ``` $blob_id $blob_id.chunk_map ``` For the nydusd =v2.2, the files in blob cache directory: ``` $blob_id.blob.data $blob_id.chunk_map ``` NOTE: nydusd (v2.2) maybe use the chunk map file of nydusd(<=v2.1), it will cause the corrupted blob cache data to be read. For the nydusd of current patch, the files in blob cache directory: ``` $blob_id.blob.data $blob_id.blob.data.chunk_map ``` NOTE: this will discard the old blob cache data and chunk map files. Signed-off-by: Yan Song <[email protected]>
imeoer
force-pushed
the
fix-chunkmap-compatibility
branch
from
baeea7f to
5e506f4
Compare
imeoer
changed the title
Codecov Report
@@ Coverage Diff @@
## master #1417 +/- ##
==========================================
- Coverage 46.45% 46.44% -0.02%
==========================================
Files 123 123
Lines 38649 38643 -6
Branches 38649 38643 -6
==========================================
- Hits 17956 17948 -8
+ Misses 19724 19721 -3
- Partials 969 974 +5
|
|
The compatibility issue was found by @ccx1024cc and @power-more, they provided a repair idea. |
jiangliu
approved these changes
Sep 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The blob cache file of nydusd v2.2 and <=v2.1 are in different
formats, which are not compatible. Should use different chunk map
files for them, in order to upgrade or downgrade smoothly.
For the nydusd <=v2.1, the files in blob cache directory:
For the nydusd =v2.2, the files in blob cache directory:
NOTE: nydusd (v2.2) maybe use the chunk map file of nydusd(<=v2.1),
it will cause the corrupted blob cache data to be read.
For the nydusd of current patch, the files in blob cache directory:
NOTE: this will discard the old blob cache data and chunk map files.
Types of changes
What types of changes does your PullRequest introduce? Put an
xin all the boxes that apply:Checklist
Go over all the following points, and put an
xin all the boxes that apply.