Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wrong values in helm chart template #242

Open
masikrus opened this issue Mar 21, 2024 · 1 comment
Open

wrong values in helm chart template #242

masikrus opened this issue Mar 21, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@masikrus
Copy link

Bug report:

$ helm pull dragonfly/dragonfly
$ tar -zxf dragonfly-1.1.33.tgz
$ grep -r Values.metrics ./dragonfly/templates/
./templates/manager/metrics-svc.yaml:{{ toYaml .Values.metrics.service.labels | indent 4 }}
./templates/seed-peer/metrics-svc.yaml:{{ toYaml .Values.metrics.service.labels | indent 4 }}
./templates/seed-client/metrics-svc.yaml:{{ toYaml .Values.metrics.service.labels | indent 4 }}
./templates/trainer/metrics-svc.yaml:{{ toYaml .Values.metrics.service.labels | indent 4 }}
./templates/scheduler/metrics-svc.yaml:{{ toYaml .Values.metrics.service.labels | indent 4 }}

i think should be
.Values.${APPNAME}.metrics.service.labels

fix please

@masikrus masikrus added the bug Something isn't working label Mar 21, 2024
@yxxhero
Copy link
Member

yxxhero commented Mar 31, 2024

@masikrus Pr is welcome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants