detect pointer type

Signed-off-by: Abhijat Malviya <[email protected]>

Author: abhijat

src/core/search/indices.h

@@ -224,9 +224,6 @@ template <typename Container, typename ItFunc> struct DefragmentMap {
       : container(container), it(f()), end(container.end()) {
   }
 
-  // Deref should be true if the value is wrapped in a pointer. Set here instead of at class level
-  // to allow overriding without specifying other parameters.
-  template <bool Deref = false>
   // The key is set if the defragmentation has to stop mid way due to depleted quota
   DefragmentResult Defragment(PageUsage* page_usage, std::string* key) {
     if (page_usage->QuotaDepleted()) {
@@ -236,13 +233,7 @@ template <typename Container, typename ItFunc> struct DefragmentMap {
     DefragmentResult result;
     for (; it != end; ++it) {
       const auto& [k, map] = *it;
-      DefragmentResult r;
-      if constexpr (Deref) {
-        r = map->Defragment(quota_usec, page_usage);
-      } else {
-        r = map.Defragment(quota_usec, page_usage);
-      }
-      if (result.Merge(std::move(r)).quota_depleted) {
+      if (result.Merge(DefragmentIndex(map, page_usage, 0)).quota_depleted) {
         *key = k;
         break;
       }
@@ -255,6 +246,19 @@ template <typename Container, typename ItFunc> struct DefragmentMap {
     return result;
   }
 
+ private:
+  template <typename T>
+  static auto DefragmentIndex(T& t, PageUsage* page_usage, int /*tag*/)
+      -> decltype(t->Defragment(page_usage)) {
+    return t->Defragment(page_usage);
+  }
+
+  template <typename T>
+  static auto DefragmentIndex(T& t, PageUsage* page_usage, char /*tag*/)
+      -> decltype(t.Defragment(page_usage)) {
+    return t.Defragment(page_usage);
+  }
+
   Container& container;
   Iterator it;
   Iterator end;

src/core/search/search.cc

@@ -629,7 +629,7 @@ DefragmentResult FieldIndices::Defragment(PageUsage* page_usage) {
                        }
                        return it;
                      }};
-    return dm.template Defragment<true>(quota_usec, page_usage, key);
+    return dm.Defragment(page_usage, key);
   };
 
   DefragmentResult result = defrag(indices_, &next_defrag_field_);

src/server/search/doc_index.cc

@@ -842,7 +842,7 @@ search::DefragmentResult ShardDocIndices::Defragment(PageUsage* page_usage) {
     return it;
   };
   search::DefragmentMap dm{indices_, std::move(begin_it)};
-  return dm.Defragment<true>(quota_usec, page_usage, &next_defrag_index_);
+  return dm.Defragment(page_usage, &next_defrag_index_);
 }
 
 }  // namespace dfly