Skip to content

Commit c84c13f

Browse files
committed
Add stub to Defrag compressed set with default return value
Signed-off-by: Abhijat Malviya <[email protected]>
1 parent d29189f commit c84c13f

File tree

2 files changed

+7
-19
lines changed

2 files changed

+7
-19
lines changed

src/core/search/block_list.cc

Lines changed: 3 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -2,20 +2,6 @@
22

33
#include "core/page_usage/page_usage_stats.h"
44

5-
namespace {
6-
7-
template <typename T>
8-
using CanDefragmentT = decltype(std::declval<T>().Defragment(std::declval<size_t>(),
9-
std::declval<dfly::PageUsage*>()));
10-
11-
template <typename, typename = void> struct CanDefragment : std::false_type {};
12-
13-
template <typename T> struct CanDefragment<T, std::void_t<CanDefragmentT<T>>> : std::true_type {};
14-
15-
template <typename T> inline constexpr bool CanDefragmentV = CanDefragment<T>::value;
16-
17-
} // namespace
18-
195
namespace dfly::search {
206

217
using namespace std;
@@ -147,11 +133,9 @@ DefragmentResult BlockList<Container>::Defragment(PageUsage* page_usage) {
147133
result.objects_moved += 1;
148134
}
149135

150-
if constexpr (CanDefragmentV<Container>) {
151-
for (Container& block : blocks_) {
152-
if (result.Merge(block.Defragment(quota_usec, page_usage)).quota_depleted) {
153-
break;
154-
}
136+
for (Container& block : blocks_) {
137+
if (result.Merge(block.Defragment(page_usage)).quota_depleted) {
138+
break;
155139
}
156140
}
157141
return result;

src/core/search/compressed_sorted_set.h

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -91,6 +91,10 @@ class CompressedSortedSet {
9191
return tail_value_.value();
9292
}
9393

94+
static DefragmentResult Defragment([[maybe_unused]] PageUsage* page_usage) {
95+
return {};
96+
}
97+
9498
private:
9599
struct EntryLocation {
96100
IntType value; // Value or 0

0 commit comments

Comments
 (0)