Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust frontend for right-to-left scripts #287

Open
lehkost opened this issue Apr 26, 2024 · 6 comments
Open

Adjust frontend for right-to-left scripts #287

lehkost opened this issue Apr 26, 2024 · 6 comments
Assignees
Labels
Milestone

Comments

@lehkost
Copy link
Member

lehkost commented Apr 26, 2024

With the advent of the Yiddish Drama Corpus on our staging server we need to adjust the frontend a bit. First step could be a right-align of both the full-text display and the header for each play.

@lehkost lehkost added the design label Apr 26, 2024
@lehkost lehkost added this to the Version 1.1.0 (Adjustments) milestone Apr 26, 2024
@cmil
Copy link
Member

cmil commented Apr 27, 2024

The header of the play is quite a complex thing. Which part of it should be right aligned? I don't think it makes sense to flip the entire header since the UI is still English and therefore left-to-right.

To give an idea of what I'm talking about, this is how the header looks if we put a dir="rtl" on its container:

image

Even if we adjust the margins and some sub element alignments, I'm not sure we should go that far.

@cmil cmil changed the title Adjust frontend for right-to-left languages Adjust frontend for right-to-left scripts Apr 27, 2024
@lehkost
Copy link
Member Author

lehkost commented Apr 29, 2024

I think @sreyfe and @sinairusinek might be best to comment needs for the r-t-l header…

As for full-text view, I would add a general linebreak (and followed by an empty line) between "Direct print source:" and the <bibl> information. It will not mix up rtl and ltr text and also make for better readability for all corpora. We might not even need to put the bibliographic record in italics anymore.

@sreyfe
Copy link

sreyfe commented Apr 29, 2024

I think it would be best for the whole header to be right-to-left. It reads strangely for the title to be all the way on the left... It's like if, in German or English, the title were all the way on the right. If we can get the spacing right, I think how it looks with an "rtl" on the div would look very good

@sreyfe
Copy link

sreyfe commented Apr 29, 2024

did a bit of mock-up:
image
just changing some padding, changing direction to rtl and alignment to right. Still not perfect, but I think this looks much more natural for Yiddish

@sreyfe
Copy link

sreyfe commented Apr 30, 2024

I think @sreyfe and @sinairusinek might be best to comment needs for the r-t-l header…

As for full-text view, I would add a general linebreak (and followed by an empty line) between "Direct print source:" and the <bibl> information. It will not mix up rtl and ltr text and also make for better readability for all corpora. We might not even need to put the bibliographic record in italics anymore.

also agree with this^

at least in the case of Yiddish, where italics don't really exist...

@sinairusinek
Copy link

Hi there! So א וואדעוויל אין איין אקט is actually not bibl information but a sub heading. Did we mark it as Bibl?!
I think the mock up version looks just right. There is also another solution which might look less odd to the non RTL reader - keeping the RTL but allign-center the entire block. But I still think this is way is exactly as I would expect it.
If anything looks odd here it is the bottom menu (downloads to Network) which could definitely come on the left - or the center, since it is in English.

densandra pushed a commit to densandra/dracor-frontend that referenced this issue Jun 1, 2024
@cmil cmil modified the milestones: Version 1.1.0 (Adjustments), Version 2.4.0 Sep 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants