Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement language switches for titles of plays #135

Open
lehkost opened this issue Dec 3, 2020 · 4 comments
Open

Implement language switches for titles of plays #135

lehkost opened this issue Dec 3, 2020 · 4 comments
Assignees

Comments

@lehkost
Copy link
Member

lehkost commented Dec 3, 2020

After implementing dracor-org/dracor-api#118 we could start implementing a language switch for titles of plays. Language codes should be delievered by the API and could then result in a switch button on corpus overview pages and pages for single plays.

@cmil
Copy link
Member

cmil commented Jan 16, 2021

If my assumption in dracor-org/dracor-api#118 (comment) is right then I would assume that this language switch would toggle between original language and English. Thus it would only make sense for non-English corpora and only if a non-English corpus has a significant number of translated titles and names.

And this toggle would then have to make clear that it only translates play titles (and possibly author names), but not the entire interface. Maybe it could be something like a checkbox with the label "Display English titles" (or maybe "Prefer English titles and names" as a site-wide preference).

@lehkost
Copy link
Member Author

lehkost commented Jan 17, 2021

In the corpus overviews, I would add a small "EN" button in both the "Authors" and "Title" column headers to switch to English author names and play titles. This way, it would be visually clear, that only these two columns are affected.

It's harder to decide where to place that "EN" button in the single-play view. On these pages we should also offer a switch to change to display English character names if available (for both the network and the character list to the right).

@cmil
Copy link
Member

cmil commented Jan 17, 2021

@lehkost is it really necessary to toggle the language on page or even column basis. It would be easier to implement this as a side wide setting with a single toggle for instance in the top navigation (maybe with a little gear icon and a menu item "Prefer English names and titles"). I think it would be more clear that this does not translate the site consistently but provides English titles only where they are available. Also, a central toggle would scale better should we decide to add more languages.

@lehkost
Copy link
Member Author

lehkost commented Jan 17, 2021

Yes, that's true – a side-wide toggle is better. We could probably describe it as "Show metadata of plays in English if available", and could detail it, if that helps to understand what the function does, to apply to "authors, titles, character names".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants