Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Serbian cities don't belong to good states #561

Open
urosctd opened this issue Jan 5, 2023 · 2 comments
Open

Serbian cities don't belong to good states #561

urosctd opened this issue Jan 5, 2023 · 2 comments

Comments

@urosctd
Copy link

urosctd commented Jan 5, 2023

All Serbian cities belong to either of two states Central Banat District or Vojvodina which is wrong.

For starters Central Banat District is a part of Vojvodina and not one of the cities in Central Banat District actually belongs there.
There are some "cities" which are rivers or mountains (Kolubara, Morava, Sokolovica), some are not in Serbia (Varna-Bulgaria, Prnjavor-Bosnia & Herzegovina) and some are districts (Pomoravlje, Šumadija).

I would like to fix data however I don't have permissions to create new branch in the repo.

Also, if I'm allowed, is changing the folder Serbia and adding to the allCitiesNested (in appropriate format) all I need to change

@jeffward01
Copy link

If you check the 'WikiData' for the Serbian cities, is the data accurate?

https://www.wikidata.org/wiki/Q497373 <--- replace the Q497373 with the appropriate WikiDataId

@urosctd
Copy link
Author

urosctd commented Mar 3, 2023

Well for Belgrade for example there is no data at all. So based on what did you get it's in Central Banat District?
https://www.wikidata.org/wiki/Q3711

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants