Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typographic mistakes & missing gmt in Timezone data #528

Open
Arkenar opened this issue Oct 18, 2022 · 0 comments
Open

Typographic mistakes & missing gmt in Timezone data #528

Arkenar opened this issue Oct 18, 2022 · 0 comments

Comments

@Arkenar
Copy link

Arkenar commented Oct 18, 2022

1/ GmtOffset & GmtOffsetName wrong TimeZone (UTC+13:45)
There is no country currently using UTC+13:45. In your project, this UTC Timezone is related to New Zealand which uses UTC+12:45 which also happens to be missing from the list of timezones.

2/ GmtOffset & GmtOffsetName missing TimeZone (UTC−12:00)
This is a timezone for United States Minor Outlying Islands which are currently listed in your project as UTC+12:00 with a "+" instead of "-". There are 37 unique gmtOffsetNames and there should be a total of 38, that's what led me to search for inconsistencies.

3/ Timezone Names typographic errors
While i was trying to normalize timezone data i decided to check for inconsistencies to sanitize. This is no big deal (mostly missing parenthesis) but it sits in the way of anyone trying to manipulate this data.

  • "Pacific Standard Time (North America" (missing closing parenthesis)
  • "Mountain Standard Time (North America" (missing closing parenthesis)
  • "Eastern Standard Time (North America" (missing closing parenthesis)
  • "Central Standard Time (North America" (missing closing parenthesis)
  • Two different spellings for Brazilia time "Brasilia Time" vs "Brasília Time" (the difference is in the letter "i")
  • "Bougainville Standard Time[6" (remove unneccessary "[6" sequence from the string)
  • Two different spellings for Amazon Time in "Amazon Time (Brazil)" and "Amazon Time (Brazil)[3" (remove unnecessary "[3" sequence from the string)
  • "Alma-Ata Time[1" (Remove unnecessary "[1" sequence from the string)
@Arkenar Arkenar changed the title Typographic errors and missing fields in Timezone data Typographic mistakes and missing gmt in Timezone data Oct 18, 2022
@Arkenar Arkenar changed the title Typographic mistakes and missing gmt in Timezone data Typographic mistakes & missing gmt in Timezone data Oct 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant