Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename "curve25519" to "salsa20-poly1305" #194

Open
DarkKirb opened this issue Apr 19, 2021 · 1 comment
Open

Rename "curve25519" to "salsa20-poly1305" #194

DarkKirb opened this issue Apr 19, 2021 · 1 comment

Comments

@DarkKirb
Copy link

The documentation currently refers to "curve25519" as an encryption algorithm, which is something it can't do.

Curve25519 is an ECDH curve which is used to generate an encryption key. Curve25519 is independent from the actual encryption method used.

I propose that we rename the "curve25519" encryption to "salsa20-poly1305" which is the encryption method used by rdedup currently. This would also allow additional encryption algorithms to be named sensibly, like for example "chacha20-poly1305", "aes256-gcm", etc.

@dpc
Copy link
Owner

dpc commented Apr 19, 2021

👍 with some backward compat. handling + warning when the old name is used.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants