Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(freecache): fix nil not hit #850

Merged
merged 4 commits into from
May 5, 2023
Merged

Conversation

PengYechang
Copy link
Contributor

Describe what this PR does / why we need it

Does this pull request fix one issue?

Describe how you did it

Describe how to verify it

Special notes for reviews

彭业昌 added 2 commits May 4, 2023 16:36
fix nil not hit
fix nil not hit
@codecov-commenter
Copy link

Codecov Report

Merging #850 (777197d) into master (965d972) will decrease coverage by 19.51%.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@             Coverage Diff             @@
##           master     #850       +/-   ##
===========================================
- Coverage   52.92%   33.42%   -19.51%     
===========================================
  Files         202      160       -42     
  Lines       11314     8450     -2864     
===========================================
- Hits         5988     2824     -3164     
- Misses       4872     5393      +521     
+ Partials      454      233      -221     

see 96 files with indirect coverage changes

Copy link

@miaofeng2027 miaofeng2027 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approve

@PengYechang PengYechang changed the title Feature/cache nil feat(freecache): fix nil not hit May 4, 2023
{
stu: nil,
},
{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里是不是可以去掉一个?

@sysulq sysulq merged commit aaa6951 into douyu:master May 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants