feat: read config from nacos #838
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@hnlq715 can help me review the code, tks. |
|
Thanks for contribution, please pass golangci-lint and add some tests to this nacos implementation. |
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## master #838 +/- ##
==========================================
+ Coverage 52.87% 52.91% +0.04%
==========================================
Files 202 202
Lines 11318 11326 +8
==========================================
+ Hits 5984 5993 +9
+ Misses 4879 4877 -2
- Partials 455 456 +1
|
|
@hnlq715 has modified, please review again. |
sysulq
approved these changes
May 9, 2023
sysulq
added a commit
that referenced
this pull request
May 9, 2023
|
@hnlq715 I saw that this PR was reverted, is there any problem? |
|
@5idu https://github.com/douyu/jupiter/actions/runs/4921729959/jobs/8791856738 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe what this PR does / why we need it
support read config from nacos datasource.
Does this pull request fix one issue?
Describe how to verify it
go run main.go --config="nacos://ip:port/config.yaml?dataId=mytest&group=xxx&namespaceId=xxx&timeout=10000&accessKey=xxx&secretKey=xxx"