-
-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added AudioTap functionality #80
base: main
Are you sure you want to change the base?
Conversation
bsneed
commented
Apr 1, 2024
•
edited
Loading
edited
- Added AudioTap class.
- Added AudioPlayer.audioTap variable.
- Taps are only actually changed when a AVPlayerItem is being observed.
- Clients can subclass AudioTap to retrieve the audio frame/buffer data.
- Added simple lifecycle test
- Depends on Added macOS support & example #79
- Fixes Expose current buffer for visualisation/waveform rendering #50
@bsneed your PR #73 there's also been some changes to add CI workflow for macOS. Would you mind rebasing? since your PR was squashed commit the easiest way will be to just apply the commits that changed:
|
Heya @dcvz, thanks! Just updated and will keep an eye on the CI here. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #80 +/- ##
==========================================
+ Coverage 78.33% 78.62% +0.29%
==========================================
Files 17 18 +1
Lines 1288 1343 +55
==========================================
+ Hits 1009 1056 +47
- Misses 279 287 +8 ☔ View full report in Codecov by Sentry. |
@bsneed I'll try to review this today or over the weekend. I've updated the example app you started to be universal for both platforms. It would be really cool to have a usage of the taps on it (a simple waveform?) in case you're interested. It's not mandatory for merge though. |