Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added AudioTap functionality #80

Open
wants to merge 13 commits into
base: main
Choose a base branch
from

Conversation

bsneed
Copy link
Contributor

@bsneed bsneed commented Apr 1, 2024

@dcvz
Copy link
Collaborator

dcvz commented Apr 11, 2024

@bsneed your PR #73 there's also been some changes to add CI workflow for macOS. Would you mind rebasing? since your PR was squashed commit the easiest way will be to just apply the commits that changed:

git rebase --onto main HEAD~X where X is the number of commits different than the base branch that got merged.

@bsneed
Copy link
Contributor Author

bsneed commented Apr 11, 2024

Heya @dcvz, thanks! Just updated and will keep an eye on the CI here.

Copy link

codecov bot commented Apr 11, 2024

Codecov Report

Attention: Patch coverage is 85.45455% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 78.62%. Comparing base (4d3c1db) to head (2f7917b).

Files Patch % Lines
Sources/SwiftAudioEx/AudioTap.swift 85.71% 7 Missing ⚠️
Sources/SwiftAudioEx/AudioPlayer.swift 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #80      +/-   ##
==========================================
+ Coverage   78.33%   78.62%   +0.29%     
==========================================
  Files          17       18       +1     
  Lines        1288     1343      +55     
==========================================
+ Hits         1009     1056      +47     
- Misses        279      287       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dcvz
Copy link
Collaborator

dcvz commented Apr 12, 2024

@bsneed I'll try to review this today or over the weekend. I've updated the example app you started to be universal for both platforms. It would be really cool to have a usage of the taps on it (a simple waveform?) in case you're interested. It's not mandatory for merge though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expose current buffer for visualisation/waveform rendering
2 participants