Skip to content

Commit ad21310

Browse files
Improved performance of sort method
1 parent 3b87ae2 commit ad21310

File tree

2 files changed

+6
-2
lines changed

2 files changed

+6
-2
lines changed

CHANGELOG.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,10 @@
11
# Changelog
22

3+
## Unreleased
4+
5+
### Changed
6+
- Improved performance of `sort` method for larger datasets. (thanks @andrewmenich)
7+
38
## 2.3.2 - 2023-05-06
49

510
### Fixed

src/services/Query.php

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -272,7 +272,6 @@ public function orderByTally(ElementQuery $query, ?string $key = null): void
272272
*
273273
* @param null|string $key
274274
* @param ElementQuery $query
275-
* @param bool $useQueryIds
276275
* @return array
277276
*/
278277
private function _elementIdsByTally(?string $key, ElementQuery $query): array
@@ -319,7 +318,7 @@ private function _elementIdsByTally(?string $key, ElementQuery $query): array
319318
->leftJoin(['subquery' => $subquery], '[[elements.id]] = [[subquery.elementId]]')
320319
->orderBy([new Expression($queryOrder)])
321320
->column();
322-
321+
323322
// Return element IDs in order of highest voted
324323
return $elementIds;
325324
}

0 commit comments

Comments
 (0)