Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What value should be provided for the Description and Description-Url parameters? #699

Open
floyd-chan opened this issue Jun 6, 2024 · 4 comments
Labels
question Answer questions and provide assistance, not an issue with source code or documentation.

Comments

@floyd-chan
Copy link

I am developing a Business Central app that requires code signing with Azure Key Vault as described here in Microsoft Learn:

https://learn.microsoft.com/en-us/dynamics365/business-central/dev-itpro/developer/devenv-sign-extension#steps-for-signing-your-app-file-with-azure-key-vault

I am going to be signing with a service principal, so this is the sample code provided on that page:

sign code azure-key-vault --azure-key-vault-url "https://MyKeyvault.vault.azure.net/" --azure-key-vault-certificate "NameOfMyCertificate" --azure-key-vault-client-id "ClientIdOfServicePrincipal" --azure-key-vault-client-secret "ClientSecretOfServicePrincipal" --azure-key-vault-tenant-id "MicrosoftEntraId" --description "Some Description" --description-url "" --verbosity Information "C:/Path/To/File(s)"

It is unclear to me what should be provided to the Description and Description-Url parameters; there is no clear documentation for this.

How should I proceed?

@floyd-chan
Copy link
Author

I just read in this post that these two parameters can be set to $null:

#642 (comment)

I've tried this, and I get this error:

Option '-u' is required.

I am still stuck and I cannot determine what to do. Help?

@dtivel
Copy link
Collaborator

dtivel commented Jun 11, 2024

@floyd-chan, the values for --description and --description-url apply to Authenticode signatures. Here is signtool.exe's description for those values:

Command Description
/d Desc Specifies a description of the signed content.
/du URL Specifies a URL for the expanded description of the signed content.

BTW, I recommend that you look at using a federated identity instead of a client secret when connecting with either GitHub Actions or Azure DevOps pipelines. In these cases, you'd use the --azure-key-vault-managed-identity parameter instead. Then, you wouldn't need to have a secret in your pipeline. @clairernovotny, can you link to samples for this?

@dlemstra
Copy link
Contributor

The --description and --description-url options were made optional in this pull request: #718.

@dtivel dtivel added the question Answer questions and provide assistance, not an issue with source code or documentation. label Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Answer questions and provide assistance, not an issue with source code or documentation.
Projects
None yet
Development

No branches or pull requests

4 participants