Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: It would be useful to be able to specify the root temporary directory. #648

Open
CZEMacLeod opened this issue Nov 3, 2023 · 1 comment
Labels
feature-request Priority:2 Work that is important, but not critical for the release

Comments

@CZEMacLeod
Copy link

When running in a container, it might be the case that there is a mounted path which is faster than the overlay filesystem for handling throwaway files.
When copying/overwriting an original file (or when the --output option is used that target folder), if the source and destination is on the same volume, it wouldn't have to do any actual data copying - especially if CoW were employed.

I think the existing DirectoryService could be augmented to take some options where the base temp directory would default to Path.GetTempPath() if it wasn't set to something else.

string path = Path.Combine(Path.GetTempPath(), Path.GetRandomFileName());

It might be possible just now to override the environment variables used when running the command to override where it thinks Temp is, but I feel it should be built into the CLI, rather than an external workaround.

I would suggest -tmp or --temp-directory as the command line option name.

Version: 0.9.1-beta.23530.1+f4efed9e8fb3296f29497b90feb6548e506f2078

@dtivel dtivel added Priority:2 Work that is important, but not critical for the release feature-request labels Nov 28, 2023
@dtivel
Copy link
Collaborator

dtivel commented Nov 28, 2023

@CZEMacLeod, thanks for the feedback.

As a workaround, I think you can override the %TEMP% environment variable just before running Sign CLI. The override only needs to be on the process, not user- or system-wide.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request Priority:2 Work that is important, but not critical for the release
Projects
None yet
Development

No branches or pull requests

2 participants