Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unsupported/unexpected timestamp allowed #624

Open
dtivel opened this issue Mar 31, 2023 · 0 comments
Open

Unsupported/unexpected timestamp allowed #624

dtivel opened this issue Mar 31, 2023 · 0 comments
Labels
bug Priority:2 Work that is important, but not critical for the release

Comments

@dtivel
Copy link
Collaborator

dtivel commented Mar 31, 2023

Describe the bug
If I hack a timestamp service to return a timestamp using SHA-1, Sign CLI blindly allows it. In the case of NuGet package signing, inner PE file timestamping succeeds, but NuGet package signing fails, and yet the overall exit code is still success (0).

Sign CLI should verify that the returned timestamp used the requested algorithm.

Repro steps
Very complicated. Need to hack the project's test timestamping service to repro.

Expected behavior
Timestamps with unsupported or unexpected algorithms should be rejected. The overall exit code should be failure.

Actual behavior
PE timestamping succeeds. NuGet package signing fails. Overall exit code is success (0).

CC @clairernovotny

@dtivel dtivel added bug Priority:2 Work that is important, but not critical for the release labels Mar 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Priority:2 Work that is important, but not critical for the release
Projects
None yet
Development

No branches or pull requests

1 participant