Fix home calculation Fixes #46821 #46836
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-Infrastructure
untriaged
There was a problem hiding this comment.
Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (2)
src/Cli/dotnet/SudoEnvironmentDirectoryOverride.cs:48
- The word 'directoy' should be 'directory'.
/// Copying instead of using the file directoy to avoid existing file being set higher permission
src/Cli/dotnet/SudoEnvironmentDirectoryOverride.cs:39
- The new behavior introduced here is not covered by tests. Please add a test to ensure that
CopyUserNuGetConfigToOverriddenHomeis only called whenhomeBeforeOverrideis not null.
if (homeBeforeOverride is not null)
kasperk81
reviewed
Feb 13, 2025
Co-authored-by: kasperk81 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #46821
#46349 was part of a set of changes to support containers that don't have HOME set to anything. Unfortunately, DOTNET_CLI_HOME (which is what we use instead) may not be set to things in other environments, notably with a zip install. Since Path.Combine is used, this led to a null pointer exception.
This changes it to use DOTNET_CLI_HOME by preference and HOME if that's undefined. If neither of those is defined, we skip copying the nuget.config to avoid an error. It's fine to not error in this case since it's best effort anyway.
/cc: @kasperk81 and @baronfel