Skip to content

[cDAC] Follow-up items from PR #126713 (typed field extension methods) #126749

@max-charlamb

Description

@max-charlamb

Follow-up items from #126713

This issue tracks outstanding items identified in the review comments on #126713 ([cDAC] Add typed field extension methods for Data classes).


1. Typed field extension methods for globals

Requested by @rcj1 in this comment: extend the new typed field helpers to cover globals (currently only per-object fields are covered).


2. Incomplete conversion — several Data classes still use old target.Read pattern

The following files were not converted to the new ReadField/ReadPointerField extension methods:

  • Debugger.cs
  • CardTableInfo.cs
  • CodeHeap.cs
  • HostCodeHeap.cs
  • RegionFreeList.cs
  • AuxiliarySymbolInfo.cs
  • InteropSyncBlockInfo.cs
  • NativeCodeVersionNode.csOptimizationTier (line 24) still uses target.Read<uint>(address + ...)
  • GCHeapSVR.csFreeableSohSegment / FreeableUohSegment use ContainsKey + ReadPointer instead of ReadPointerFieldOrNull

cc @max-charlamb @rcj1

Metadata

Metadata

Assignees

No one assigned

    Labels

    area-Diagnostics-cdacenhancementProduct code improvement that does NOT require public API changes/additions

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions