Follow-up items from #126713
This issue tracks outstanding items identified in the review comments on #126713 ([cDAC] Add typed field extension methods for Data classes).
1. Typed field extension methods for globals
Requested by @rcj1 in this comment: extend the new typed field helpers to cover globals (currently only per-object fields are covered).
2. Incomplete conversion — several Data classes still use old target.Read pattern
The following files were not converted to the new ReadField/ReadPointerField extension methods:
Debugger.cs
CardTableInfo.cs
CodeHeap.cs
HostCodeHeap.cs
RegionFreeList.cs
AuxiliarySymbolInfo.cs
InteropSyncBlockInfo.cs
NativeCodeVersionNode.cs — OptimizationTier (line 24) still uses target.Read<uint>(address + ...)
GCHeapSVR.cs — FreeableSohSegment / FreeableUohSegment use ContainsKey + ReadPointer instead of ReadPointerFieldOrNull
cc @max-charlamb @rcj1
Follow-up items from #126713
This issue tracks outstanding items identified in the review comments on #126713 ([cDAC] Add typed field extension methods for Data classes).
1. Typed field extension methods for globals
Requested by @rcj1 in this comment: extend the new typed field helpers to cover globals (currently only per-object fields are covered).
2. Incomplete conversion — several Data classes still use old
target.ReadpatternThe following files were not converted to the new
ReadField/ReadPointerFieldextension methods:Debugger.csCardTableInfo.csCodeHeap.csHostCodeHeap.csRegionFreeList.csAuxiliarySymbolInfo.csInteropSyncBlockInfo.csNativeCodeVersionNode.cs—OptimizationTier(line 24) still usestarget.Read<uint>(address + ...)GCHeapSVR.cs—FreeableSohSegment/FreeableUohSegmentuseContainsKey+ReadPointerinstead ofReadPointerFieldOrNullcc @max-charlamb @rcj1