Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JIT: Assertion failed '(newLayoutCost < currLayoutCost) || Compiler::fgProfileWeightsEqual(newLayoutCost, currLayoutCost, 0.001)' during 'Optimize layout' #109984

Closed
amanasifkhalid opened this issue Nov 19, 2024 · 2 comments · Fixed by #110069
Closed

JIT: Assertion failed '(newLayoutCost < currLayoutCost) || Compiler::fgProfileWeightsEqual(newLayoutCost, currLayoutCost, 0.001)' during 'Optimize layout' #109984

amanasifkhalid opened this issue Nov 19, 2024 · 2 comments · Fixed by #110069
Assignees
@amanasifkhalid
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI blocking-clean-ci-optional Blocking optional rolling runs in-pr There is an active PR which will close this issue when it is merged
Milestone
10.0.0

Comments

@amanasifkhalid
Copy link
Member

Hitting in libraries-jitstress again (example run). Looks like #109835 didn't completely fix #109831.

cc @dotnet/jit-contrib
@amanasifkhalid amanasifkhalid added area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI blocking-clean-ci-optional Blocking optional rolling runs labels Nov 19, 2024
@amanasifkhalid amanasifkhalid added this to the 10.0.0 milestone Nov 19, 2024
@amanasifkhalid amanasifkhalid self-assigned this Nov 19, 2024
@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

@amanasifkhalid amanasifkhalid mentioned this issue Nov 19, 2024
Merged
@amanasifkhalid
Copy link
Member Author

This assert also hit in the last Antigen run.

@amanasifkhalid amanasifkhalid mentioned this issue Nov 21, 2024
Merged
@dotnet-policy-service dotnet-policy-service bot added the in-pr There is an active PR which will close this issue when it is merged label Nov 21, 2024
mikelle-rogers pushed a commit to mikelle-rogers/runtime that referenced this issue Dec 10, 2024
@amanasifkhalid @mikelle-rogers
JIT: Skip cost improvement check in 3-opt for exceptionally costly la…
2027f69 
…youts (dotnet#110069)

Fixes dotnet#109984.
@github-actions github-actions bot locked and limited conversation to collaborators Dec 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@amanasifkhalid amanasifkhalid

Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI blocking-clean-ci-optional Blocking optional rolling runs in-pr There is an active PR which will close this issue when it is merged
Projects
None yet
Milestone
10.0.0
Development

Successfully merging a pull request may close this issue.

JIT: Skip cost improvement check in 3-opt for exceptionally costly layouts amanasifkhalid/runtime
1 participant
@amanasifkhalid