Add few interpreter bringup diagnostic improvements (#116699)

This change improves the diagnosability of the interpreter issues during
the bringup. It prints out unsupported IL opcodes when we hit one and
also makes the assert go through the assertAbort instead of the regular
assert, since the regular one pops out a dialog, so it is bad for batch
testing.

Author: janvorli

src/coreclr/interpreter/compiler.cpp

@@ -47,6 +47,14 @@ void DECLSPEC_NORETURN Interp_NOMEM()
     throw std::bad_alloc();
 }
 
+void AssertOpCodeNotImplemented(const uint8_t *ip, size_t offset)
+{
+    fprintf(stderr, "IL_%04x %-10s - opcode not supported yet\n",
+                (int32_t)(offset),
+                CEEOpName(CEEDecodeOpcode(&ip)));
+    assert(!"opcode not implemented");
+}
+
 // GCInfoEncoder needs an IAllocator implementation. This is a simple one that forwards to the Compiler.
 class InterpIAllocator : public IAllocator
 {
@@ -4570,8 +4578,11 @@ int InterpCompiler::GenerateCode(CORINFO_METHOD_INFO* methodInfo)
                         break;
                     }
                     default:
-                        assert(0);
+                    {
+                        const uint8_t *ip = m_ip - 1;
+                        AssertOpCodeNotImplemented(ip, ip - m_pILCode);
                         break;
+                    }
                 }
                 break;
 
@@ -5070,8 +5081,10 @@ int InterpCompiler::GenerateCode(CORINFO_METHOD_INFO* methodInfo)
                 break;
             }
             default:
-                assert(0);
+            {
+                AssertOpCodeNotImplemented(m_ip, m_ip - m_pILCode);
                 break;
+            }
         }
     }
 
@@ -5095,6 +5108,7 @@ int InterpCompiler::GenerateCode(CORINFO_METHOD_INFO* methodInfo)
 
     return CORJIT_OK;
 exit_bad_code:
+    assert(!m_hasInvalidCode);
     return CORJIT_BADCODE;
 }
 

src/coreclr/interpreter/interpreter.h

@@ -25,3 +25,8 @@
 
 #define ALIGN_UP_TO(val,align) ((((size_t)val) + (size_t)((align) - 1)) & (~((size_t)(align - 1))))
 
+#ifdef _DEBUG
+extern "C" void assertAbort(const char* why, const char* file, unsigned line);
+#undef assert
+#define assert(p) (void)((p) || (assertAbort(#p, __FILE__, __LINE__), 0))
+#endif // _DEBUG