Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Partial properties needs to enforce that all implementation part accessors have bodies #74221

Closed
RikkiGibson opened this issue Jul 1, 2024 · 0 comments · Fixed by #74224
Closed

Partial properties needs to enforce that all implementation part accessors have bodies #74221

RikkiGibson opened this issue Jul 1, 2024 · 0 comments · Fixed by #74224
Assignees
@RikkiGibson
Labels
Area-Compilers Bug New Feature - Partial Properties
Milestone
17.12

Comments

@RikkiGibson
Copy link
Contributor

RikkiGibson commented Jul 1, 2024 •
edited by jcouv
Loading

SharpLab

partial class C {
  public partial int Prop { get; set; }
}

partial class C {
  public partial int Prop { get => 1; set; }
}

Expected behavior: error is reported on 'set' accessor of implementation part.
Actual behavior: NRE in emit layer

Relates to test plan #73090
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-Compilers untriaged Issues and PRs which have not yet been triaged by a lead labels Jul 1, 2024
@RikkiGibson RikkiGibson added this to the 17.12 milestone Jul 1, 2024
@RikkiGibson RikkiGibson self-assigned this Jul 1, 2024
@RikkiGibson RikkiGibson added Bug and removed untriaged Issues and PRs which have not yet been triaged by a lead labels Jul 1, 2024
@RikkiGibson RikkiGibson mentioned this issue Jul 1, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@RikkiGibson RikkiGibson

Labels
Area-Compilers Bug New Feature - Partial Properties
Projects
None yet
Milestone
17.12
Development

Successfully merging a pull request may close this issue.

Report a diagnostic on missing body in partial property implementation RikkiGibson/roslyn
2 participants
@RikkiGibson @jcouv