Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create dotnet tool for many of the scripts/tools in this repo #1168

Open
3 of 6 tasks
JoeRobich opened this issue Feb 4, 2022 · 5 comments
Open
3 of 6 tasks

Create dotnet tool for many of the scripts/tools in this repo #1168

JoeRobich opened this issue Feb 4, 2022 · 5 comments

Comments

@JoeRobich
Copy link
Member

JoeRobich commented Feb 4, 2022

We should empower Roslyn devs with the ability to perform more infra tasks and make it easier to get answers to common infra questions.

We can start by migrating several existing scripts/tools to run from a common tool.

Possible Subcommands

@JoeRobich
Copy link
Member Author

JoeRobich commented Mar 28, 2022

Instead of taking this PR (#906) we should move RIT functionality to dotnet-roslyn (#1168) as a set of subcommands which correspond to various scripts create-insertion (OneOffInsertion), create-dummy-insertion (CreateDummyPR), update-insertion, & overwrite-insertion (UpdateExistingPR).

Feel free to suggest that create-dummy-insertion could be a --dummy flag on create-insertion. Or that overwrite-insertion could be an --overwrite flag on update-insertion.

@dibarbet
Copy link
Member

Which VS includes this PR/commit (New tool)

It would be nice if we could actually tag the github PR with a linked to the merged insertion somehow (comment might be too noisy, maybe we can edit the description?)

@dibarbet
Copy link
Member

Create VS Insertions (Roslyn Insertion Tool)

We should clean up the RIT as part of this (remove the powershell scripts, consolidate the flags where possible). For example /updateexistingpr and /overwritepr could conceivably be combined since 90% of the time we use both together

@JoeRobich
Copy link
Member Author

It would be nice if we could actually tag the github PR with a linked to the merged insertion somehow (comment might be too noisy, maybe we can edit the description?)

You are talking about #1177, comment is good because it creates a notification that would alert the author or collaborators that it is available for verification. We should probably also look at linked issues and give them notice as well. vs code's github issue bot made this a very nice experience when I encountered it this week.

@JoeRobich
Copy link
Member Author

We should clean up the RIT as part of this (remove the powershell scripts, consolidate the flags where possible). For example /updateexistingpr and /overwritepr could conceivably be combined since 90% of the time we use both together

RIT will no longer get updates once the roslyn-tools tool has these subcommands. We will help partner teams migrate their insertion pipelines to the new tool and archive RIT.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants