Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow adding assembly-level attribute for code generation via MSBuild #9202

Open
kzu opened this issue Oct 23, 2024 · 0 comments
Open

Allow adding assembly-level attribute for code generation via MSBuild #9202

kzu opened this issue Oct 23, 2024 · 0 comments

Comments

@kzu
Copy link
Contributor

kzu commented Oct 23, 2024

Having to add [assembly: GenerateCodeForDeclaringAssembly] is a bit hard to discover, especially when types being used come from nuget packages.

It might be valuable to also offer an MSBuild alternative, just like [InternalsVisibleTo...] can now be done with <InternalsVisibleTo Include=".." /> directly in the csproj.

Something like the following:

<ItemGroup>
   <OrleansGenenerator Include="AssemblyPotentiallyFromPackage" />
</ItemGroup>

This way, it should even be possible for the nuget packages themselves to provide this item automatically so that scenarios that use those types in Orleans context, Just Work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant