Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion - Add a reserved PropertyGroup / ItemGroup Type #11189

Open
JanKrivanek opened this issue Dec 23, 2024 · 0 comments
Open

Suggestion - Add a reserved PropertyGroup / ItemGroup Type #11189

JanKrivanek opened this issue Dec 23, 2024 · 0 comments

Comments

@JanKrivanek
Copy link
Member

Context

If we are ever going to lift the 'sensitive data as a 1st class citizen' topic (https://github.com/dotnet/msbuild/blob/main/documentation/specs/proposed/security-metadata.md) - the nonbreaking way of marking the data type(s) would be handy.

To prepare for this we should consider adding the 'Type' attribute to PropertyGroup / ItemGroup that is accepted, but not interpreted in any way - similarly to the 'Label' attribute:

<xs:attribute name="Label" type="xs:string" use="optional">
<xs:annotation>
<xs:documentation><!-- _locID_text="PropertyGroupType_Label" _locComment="" -->Optional expression. Used to identify or order system and user elements</xs:documentation>
</xs:annotation>
</xs:attribute>

This way we could then add the interpretation in future release, while not requiring backward incompatible formats.

Downside - The incompatibility of such marking with old .NET Framework versions of MSBuild would still not be prevented.
However it's very cheap and low risk change, that should be considered even if it's highly likely we won't use it in the future - as they say 'next best time is now'

FYI - @rainersigwald, @baronfel

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant