Skip to content

.NET: Unify the MonoMacResourcePrefix, XamMacResourcePrefix and IPhoneResourcePrefix MSBuild properties #12808

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rolfbjarne opened this issue Sep 22, 2021 · 3 comments · May be fixed by #22840
Assignees
Labels
dotnet An issue or pull request related to .NET (6) enhancement The issue or pull request is an enhancement good first issue This is a good first issue for someone to start working with our code
Milestone

Comments

@rolfbjarne
Copy link
Member

We have the IPhoneResourcePrefix property for Xamarin.iOS and the MonoMacResourcePrefix and XamMacResourcePrefix properties for Xamarin.Mac.

We should unify these for .NET.

Maybe just use ResourcePrefix? Other ideas?

@rolfbjarne rolfbjarne added enhancement The issue or pull request is an enhancement dotnet An issue or pull request related to .NET (6) dotnet-pri3 .NET 6: wishlist for stable release labels Sep 22, 2021
@rolfbjarne rolfbjarne added this to the .NET 6 milestone Sep 22, 2021
@dalexsoto
Copy link
Member

Are we likely to collide with something already out there if we use ResourcePrefix as the name? I want to avoid another NativeReference kind of situation, maybe call it MaciOSResourcePrefix?

@rolfbjarne rolfbjarne modified the milestones: .NET 6, .NET 7 Dec 9, 2021
@rolfbjarne rolfbjarne removed the dotnet-pri3 .NET 6: wishlist for stable release label Aug 26, 2022
@rolfbjarne
Copy link
Member Author

rolfbjarne commented Aug 26, 2022

What about AppBundleResourcePrefix?

See also: #12807 (comment)

@rolfbjarne rolfbjarne modified the milestones: .NET 7, .NET 8 Aug 26, 2022
@rolfbjarne rolfbjarne added the good first issue This is a good first issue for someone to start working with our code label Aug 26, 2022
@rolfbjarne rolfbjarne modified the milestones: .NET 8, .NET 9 Sep 12, 2023
@github-project-automation github-project-automation bot moved this to Technical Debt in .NET 9 Aug 27, 2024
@rolfbjarne rolfbjarne modified the milestones: .NET 9, .NET 10 Sep 27, 2024
@rolfbjarne rolfbjarne removed this from .NET 9 Sep 27, 2024
@rolfbjarne
Copy link
Member Author

We also have logic to handle multiple resource prefixes (although it doesn't seem to be tested nor fully working, see #20968), so maybe we should just use an item group, say AppBundleResourcePrefixes instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dotnet An issue or pull request related to .NET (6) enhancement The issue or pull request is an enhancement good first issue This is a good first issue for someone to start working with our code
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants