Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WebToolsE2E][docs] Do the samples need to be updated to NET9? Because existing .NET applications (NET8.0) cannot reference .NET Aspire 9. #2028

Open
v-sherryfan opened this issue Nov 8, 2024 · 2 comments
Labels
needs-more-info Needs more info from OP. Auto-closed after 2 weeks if no response. [org][resolution]

Comments

@v-sherryfan
Copy link

v-sherryfan commented Nov 8, 2024

Describe the issue or suggestion

Issue description:
In Tutorial: Add .NET Aspire to an existing .NET app doc, we need to make some updates to the instructions.

Issue 1:

  • For eShopLite sample, Do we need to add support for aspire9? Its default target is 8.0, but we have supported aspire9 templates for some time. If users use CLI to create aspire templates according to the documentation, the highest version of aspire9 will be created by default (assuming that the user has an aspire9 environment), which will not match the samples version.

Issue 2:

  • The .NET CLI part of the document also needs to add aspire9 related instructions

Issue 3:

  • For step 3 in this Explore the sample app section, do we need to add instructions to navigate to /api/Product?
    Image
    Actual:
    Image
    Expected:
    Image
@v-sherryfan v-sherryfan changed the title [WebToolsE2E] Do the samples need to be updated to NET9? Because existing .NET applications (NET8.0) cannot reference .NET Aspire 9. [WebToolsE2E][docs] Do the samples need to be updated to NET9? Because existing .NET applications (NET8.0) cannot reference .NET Aspire 9. Nov 8, 2024
@maddymontaquila
Copy link
Member

@v-sherryfan can you try again but let the terminal live a bit longer? That localhost issue happens when the dashboard hasn't fully spun up yet. Aspire 9 should work with .NET 8 projects.

@maddymontaquila maddymontaquila added the needs-more-info Needs more info from OP. Auto-closed after 2 weeks if no response. [org][resolution] label Nov 19, 2024
@v-sherryfan
Copy link
Author

@maddymontaquila I have my dashboard fully up and running but I still have this issue.

Yes, Aspire 9 can be used with .NET 8 projects. I think the issue I was trying to describe initially was that referencing aspire9 for an existing net8 project failed on vscode, so I recommended updating to net9 at that time. I have opened product issue 2299835 to track this issue of referencing aspire9 for net8 failing. Therefore, issues 1 and 2 in this question can be ignored and only issue 3 is valid.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-more-info Needs more info from OP. Auto-closed after 2 weeks if no response. [org][resolution]
Projects
None yet
Development

No branches or pull requests

2 participants