Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] PDF Download not appearing for nested TOC #10338

Open
kontax85 opened this issue Oct 31, 2024 · 3 comments
Open

[Bug] PDF Download not appearing for nested TOC #10338

kontax85 opened this issue Oct 31, 2024 · 3 comments
Labels
bug A bug to fix

Comments

@kontax85
Copy link

kontax85 commented Oct 31, 2024

Describe the bug
Using nested TOCs the Download PDF is not available. The PDF files are correctly generated. The download PDF option appears only when the master TOC has PDF generation enabled.

To Reproduce
Content of docfx.json:

"globalMetadata": {
"pdfTocPage": true
}

Content of the master TOC:

items:

  • name: Italian Bank Integration
    href: ItalianBankIntegration/toc.yml
    homepage: ItalianBankIntegration/intro.md

Content of the nested TOC:

pdf: true
pdfFileName: ItalianBankIntegration.pdf
pdfCoverPage: covers/ItalianBankIntegration.html
href: intro.md
items:

  • name: XXX
    href: XXX.md

The template is modern.

Expected behavior
The PDF Download option should appear in the bottom left area when selecting the menu area related to this TOC.

Context (please complete the following information):

  • OS: Windows
  • Docfx version: 2.77.0
@kontax85 kontax85 added the bug A bug to fix label Oct 31, 2024
@lanthonyneville
Copy link

This sounds like what I reported in #10329 ... do you agree?

@kontax85
Copy link
Author

kontax85 commented Nov 4, 2024

Hi @lanthonyneville ,
actually I don't think that it is the same issue, the left pane in my case is rendered (the TOC is visible) but there is no PDF Download Link navigating the nested TOC.

Image

@lanthonyneville
Copy link

Hi @lanthonyneville , actually I don't think that it is the same issue, the left pane in my case is rendered (the TOC is visible) but there is no PDF Download Link navigating the nested TOC.

Yes, its different.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A bug to fix
Projects
None yet
Development

No branches or pull requests

2 participants