Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The dotnet-diagnostics and dotnet-netnative repos "Windows ARM" legs not building anymore #4606

Open
mikem8361 opened this issue Dec 4, 2024 · 5 comments

Comments

@mikem8361
Copy link
Member

mikem8361 commented Dec 4, 2024

Build

It looks like the Windows image 1es-windows-2022 version 20241125.1.0 has changed and no longer cross builds the Windows arm platform. Version 20241021.1.0 did succeed. This image built the Windows ARM leg just fine last week.

I tried the "windows.vs2022.amd64" image with the same result. It looks to me like both images contain the right VS components:

Microsoft.VisualStudio.Component.VC.Tools.ARM | 17.12.35410.122
Microsoft.VisualStudio.Component.VC.Tools.ARM64 | 17.12.35410.122
Microsoft.VisualStudio.Component.VC.Tools.ARM64EC | 17.12.35410.122
Microsoft.VisualStudio.Component.VC.Tools.x86.x64 | 17.12.35410.122

Microsoft.VisualStudio.Component.VC.ATL | 17.12.35410.122 |
Microsoft.VisualStudio.Component.VC.ATL.ARM | 17.12.35410.122 |
Microsoft.VisualStudio.Component.VC.ATL.ARM.Spectre | 17.12.35410.122 |
Microsoft.VisualStudio.Component.VC.ATL.ARM64 | 17.12.35410.122 |
Microsoft.VisualStudio.Component.VC.ATL.ARM64.Spectre | 17.12.35410.122 |
Microsoft.VisualStudio.Component.VC.ATL.Spectre | 17.12.35410.122 |

The Windows_arm_Release leg is failing because in the newer Windows images there isn’t an arm C++ install (I think).
https://dev.azure.com/dnceng/internal/_build/results?buildId=2593861&view=logs&j=88bbb24c-ddc8-570d-6cfd-a8491c743b50&t=6e73c14f-8d75-507d-26bc-9ef679dd3404

The build has recently succeed here:
https://dev.azure.com/dnceng/internal/_build/results?buildId=2577280&view=logs&j=7640ddf0-eb3e-5982-6d08-3616cbae7b56&t=822b042b-ab79-510d-6d33-61d6d4a15b10

Build details for the dotnet-diagnostics repo using the NetCore1ESPool-Svc-Internal pool:

Time Elapsed 00:03:29.42
BUILD: Starting Build at  7:00:39.44
D:\a\_work\1\s\.packages\
BUILD: Commencing diagnostics repo build
BUILD: Checking prerequisites
BUILD: Commencing build of native components for Windows_NT.arm.Release
BUILD: Using environment: "C:\Program Files\Microsoft Visual Studio\2022\Enterprise\Common7\Tools\\..\..\VC\Auxiliary\Build\vcvarsall.bat" amd64
**********************************************************************
** Visual Studio 2022 Developer Command Prompt v17.12.1
** Copyright (c) 2022 Microsoft Corporation
**********************************************************************
[vcvarsall.bat] Environment initialized for: 'x64'
Generating Version Header
 Determining projects to restore...
 Restored D:\a\_work\1\s\eng\native-prereqs.proj (in 111 ms).
 
Build succeeded.
   0 Warning(s)
   0 Error(s)
 
Time Elapsed 00:00:01.61
BUILD: Regenerating the Visual Studio solution
Not searching for unused variables given on the command line.
-- Selecting Windows SDK version 10.0.26100.0 to target Windows 10.0.
CMake Error at CMakeLists.txt:10 (project):
 
 Failed to run MSBuild command:
 
   C:/Program Files/Microsoft Visual Studio/2022/Enterprise/MSBuild/Current/Bin/amd64/MSBuild.exe
 
 to get the value of VCTargetsPath:
 
   MSBuild version 17.12.6+db5f6012c for .NET Framework
   Build started 12/3/2024 7:00:58 AM.
   
   Project "D:\a\_work\1\s\artifacts\obj\Windows_NT.arm.Release\CMakeFiles\3.31.0\VCTargetsPath.vcxproj" on node 1 (default targets).
   C:\Program Files\Microsoft Visual Studio\2022\Enterprise\MSBuild\Microsoft\VC\v170\Microsoft.Cpp.WindowsSDK.targets(49,5): error MSB8037: The Windows SDK version 10.0.26100.0 for Desktop C++ ARM Apps was not found. Install the required version of Windows SDK or change the SDK version in the project property pages or by right-clicking the solution and selecting "Retarget solution".  [D:\a\_work\1\s\artifacts\obj\Windows_NT.arm.Release\CMakeFiles\3.31.0\VCTargetsPath.vcxproj]
   Done Building Project "D:\a\_work\1\s\artifacts\obj\Windows_NT.arm.Release\CMakeFiles\3.31.0\VCTargetsPath.vcxproj" (default targets) -- FAILED.
   
   Build FAILED.
   
   "D:\a\_work\1\s\artifacts\obj\Windows_NT.arm.Release\CMakeFiles\3.31.0\VCTargetsPath.vcxproj" (default target) (1) ->
   (_CheckWindowsSDKInstalled target) -> 
     C:\Program Files\Microsoft Visual Studio\2022\Enterprise\MSBuild\Microsoft\VC\v170\Microsoft.Cpp.WindowsSDK.targets(49,5): error MSB8037: The Windows SDK version 10.0.26100.0 for Desktop C++ ARM Apps was not found. Install the required version of Windows SDK or change the SDK version in the project property pages or by right-clicking the solution and selecting "Retarget solution".  [D:\a\_work\1\s\artifacts\obj\Windows_NT.arm.Release\CMakeFiles\3.31.0\VCTargetsPath.vcxproj]

Build leg reported

https://dev.azure.com/dnceng/internal/_build/results?buildId=2593861&view=logs&j=88bbb24c-ddc8-570d-6cfd-a8491c743b50&t=6e73c14f-8d75-507d-26bc-9ef679dd3404

Pull Request

https://dev.azure.com/dnceng/internal/_git/dotnet-diagnostics/pullrequest/45578

Known issue core information

No response

Additional information about the issue reported

No response

Known Issue Error Message

Fill the error message using step by step known issues guidance.

{
  "ErrorMessage": "",
  "ErrorPattern": "",
  "BuildRetry": false,
  "ExcludeConsoleLog": false
}

Report

Summary

24-Hour Hit Count 7-Day Hit Count 1-Month Count
0 0 0
@dougbu
Copy link
Member

dougbu commented Dec 4, 2024

please include information only about your failures when using the windows.vs2022.amd64 image. we have no control over what's on 1es-windows-2022

@mikem8361
Copy link
Member Author

We decided to remove our Windows ARM32 support so it makes this problem moot.

@eduardo-vp
Copy link
Member

Hi, actually we need to be able to build targeting arm32 for the dotnet-netnativelegacy repo but we hit the same issue, the image is not able to build for arm32.

You may find the full logs here: https://dev.azure.com/dnceng/internal/_build/results?buildId=2596191&view=logs&j=d25e1be0-2c40-54f7-c4f2-6c08c695c10f&t=0d994932-ea73-5332-d629-cb50e0ff4f0b.

@dougbu dougbu reopened this Dec 6, 2024
@dougbu
Copy link
Member

dougbu commented Dec 6, 2024

reopening in light of ^^

but again if dotnet-nativelegacy is also using one of the 1es-windows-* images, there's not much DNCEng can do to help.

more importantly, we need more information to make this actionable. please create a DTL machine (assuming your issue is with one of the non-1ES build images listed on https://helix.dot.net/), and determine what VS component or component version we need to add to that build image.

@eduardo-vp
Copy link
Member

eduardo-vp commented Dec 13, 2024

Duplicate of actions/runner-images#10981, should be okay to close the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants