Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When missing add name of argument for command to error message #1074

Open
zpittmansf opened this issue Nov 9, 2020 · 3 comments
Open

When missing add name of argument for command to error message #1074

zpittmansf opened this issue Nov 9, 2020 · 3 comments
Labels
Area-Help enhancement New feature or request

Comments

@zpittmansf
Copy link
Contributor

zpittmansf commented Nov 9, 2020 •
edited
Loading

Instead of "Required argument missing for command: {commandname}", provide "Required argument {argumentname} missing for command: {commandname}" for better clarity as to which required argument is missing.

command-line-api/src/System.CommandLine/ValidationMessages.cs

Line 53 in a521704

? $"Required argument missing for command: {symbolResult.Token().Value}"

@jonsequitur jonsequitur added enhancement New feature or request Area-Help labels Nov 11, 2020
Drizin added a commit to Drizin/CodegenCS-command-line-api that referenced this issue Aug 29, 2022
@Drizin
Refs dotnet#1074 - Instead of "Required argument missing for command:…
49371bc 
… {commandname}", should provide "Required argument {argumentname} missing for command: {commandname}" for better clarity as to which required argument is missing.
@Forge36
Copy link

Forge36 commented Dec 13, 2022 •
edited
Loading

@Drizin appears to have a proof of concept 49371bc. What additional changes or review is needed?

From reviewing: CONTRIBUTING.md

  • A minimal reproduction - Is this required in this instance?
  • Unit Tests
  • Breaking Changes? (This doesn't appear to be, I haven't dug in to confirm with testing)

Drizin added a commit to Drizin/CodegenCS-command-line-api that referenced this issue Dec 13, 2022
@Drizin
Refs dotnet#1074 - Instead of "Required argument missing for command:…
d5515b7 
… {commandname}", should provide "Required argument {argumentname} missing for command: {commandname}" for better clarity as to which required argument is missing.
@Drizin
Copy link

Drizin commented Dec 13, 2022 •
edited
Loading

@Forge36 thanks for bringing this.
I've just submitted PR 1993 with that improvement.

Drizin added a commit to Drizin/CodegenCS-command-line-api that referenced this issue Dec 13, 2022
@Drizin
Refs dotnet#1074 - Instead of "Required argument missing for command:…
edf2982 
… {commandname}", should provide "Required argument {argumentname} missing for command: {commandname}" for better clarity as to which required argument is missing.
Drizin added a commit to Drizin/CodegenCS-command-line-api that referenced this issue Dec 13, 2022
@Drizin
Refs dotnet#1074 - Instead of "Required argument missing for command:…
34a1981 
… {commandname}", should provide "Required argument {argumentname} missing for command: {commandname}" for better clarity as to which required argument is missing.
@TMUNYU
Copy link

TMUNYU commented Oct 27, 2023

Any news on this issue? Seems the PR has been open a while now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-Help enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@jonsequitur @TMUNYU @Drizin @Forge36 @zpittmansf