Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WebToolsE2E][Aspire] The attribute value column in the resource table does not support sorting yet. #6008

Open
v-sherryfan opened this issue Sep 29, 2024 · 3 comments · May be fixed by #6975
Open

[WebToolsE2E][Aspire] The attribute value column in the resource table does not support sorting yet. #6008

v-sherryfan opened this issue Sep 29, 2024 · 3 comments · May be fixed by #6975
Labels
area-dashboard untriaged New issue has not been triaged

Comments

@v-sherryfan
Copy link

REGRESSION INFO: This is a new feature added in Aspire 9.0 RC1

INSTALL STEPS

  1. Clean machine: Win11 x64 23h2 ENU
  2. Install SDK 8.0.402
  3. Install Aspire 9.0 RC1 [9.0.0-preview.4.24478.1]

REPRO STEPS

  1. Open CMD, run following command to create an Aspire Starter App project
dotnet new aspire-starter -o AspireStarterApp
cd AspireStarterApp/AspireStarterApp.AppHost
  1. Dotnet run the project in CMD, and open URL in the browser.
    dotnet run
  2. Go to Resources page, click a resource. The attribute value column in the resource table does not support sorting.

ACTUAL
In the Resource table, the Value column does not support sorting.
image

EXPECTED
Should have the same appearance and functionality as the endpoint and environment variables tables.
image
@v-sherryfan
Copy link
Author

I see that issue #5377 has been fixed in Aspire 9.0 RC1, but the attribute value column in the resource table still does not support sorting. So I opened this issue to confirm whether it is by design.

@adamint
Copy link
Member

adamint commented Oct 14, 2024

We explicit set sortable to false in ResourceDetails, but before closing as by design, tagging @JamesNK

@JamesNK
Copy link
Member

JamesNK commented Oct 15, 2024

I'm not sure why it is false. Is there a reason to not make it true and consistent?

@joperezr joperezr added the untriaged New issue has not been triaged label Oct 15, 2024
@adamint adamint linked a pull request Dec 20, 2024 that will close this issue
Open
18 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-dashboard untriaged New issue has not been triaged
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow sorting resource attributes in resource details, don't sort masked values adamint/aspire
5 participants
@davidfowl @JamesNK @joperezr @adamint @v-sherryfan