Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update bundled jQuery 3.5.1 to 3.7.1 #3002

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

wenz
Copy link
Contributor

@wenz wenz commented Oct 8, 2024

Update bundled jQuery 3.5.1 to 3.7.1

  • Replace local versions of jQuery and jQuery.slim, including minified files and map files
  • Update reference in Identity template's _Layout.cshtml file to version 3.7.1 from CDN

Fixes #3001

MackinnonBuck
MackinnonBuck previously approved these changes Oct 9, 2024
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How were these map files obtained? The map files I get from installing jquery via npm don't result in a diff here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was using https://code.jquery.com/jquery-3.7.1.min.map and https://code.jquery.com/jquery-3.7.1.slim.min.map, linked from https://jquery.com/download/, but changed the file name inside the map file to match what the templates are using (so without the version number).

@MackinnonBuck MackinnonBuck dismissed their stale review October 9, 2024 20:23

Accidentally approved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update jQuery 3.5.1 to 3.7.1
2 participants