Merge pull request #28 from dotnet-campus/t/lvyi/case

更准确判断 PascalCase 命名规则 + 消除所有警告

Author: kkwpsv

build/Version.props

@@ -1,5 +1,5 @@
 <Project>
   <PropertyGroup>
-    <Version>3.2.0</Version>
+    <Version>3.2.1</Version>
   </PropertyGroup>
 </Project>

src/dotnetCampus.CommandLine.Analyzer/AnalyzerReleases.Shipped.md

@@ -0,0 +1,11 @@
+; Shipped analyzer releases
+; https://github.com/dotnet/roslyn-analyzers/blob/master/src/Microsoft.CodeAnalysis.Analyzers/ReleaseTrackingAnalyzers.Help.md
+
+## Release 3.2
+
+### New Rules
+Rule ID | Category | Severity | Notes
+--------|----------|----------|-------
+DCL101 | dotnetCampus.Naming | Error | <https://github.com/dotnet-campus/dotnetCampus.CommandLine/blob/master/docs/analyzers/DCL101.md>
+DCL201 | dotnetCampus.Usage | Hidden | <https://github.com/dotnet-campus/dotnetCampus.CommandLine/blob/master/docs/analyzers/DCL201.md>
+DCL202 | dotnetCampus.Usage | Error | <https://github.com/dotnet-campus/dotnetCampus.CommandLine/blob/master/docs/analyzers/DCL202.md>

src/dotnetCampus.CommandLine.Analyzer/AnalyzerReleases.Unshipped.md

@@ -0,0 +1,2 @@
+; Unshipped analyzer release
+; https://github.com/dotnet/roslyn-analyzers/blob/master/src/Microsoft.CodeAnalysis.Analyzers/ReleaseTrackingAnalyzers.Help.md

src/dotnetCampus.CommandLine.Analyzer/Analyzers/OptionLongNameMustBePascalCaseAnalyzer.cs

@@ -101,13 +101,18 @@ private void AnalyzeProperty(SyntaxNodeAnalysisContext context)
             var argumentList = attributeSyntax.ChildNodes().OfType<AttributeArgumentListSyntax>().FirstOrDefault();
             if (argumentList != null)
             {
-                var expressions = argumentList.ChildNodes().OfType<AttributeArgumentSyntax>().Select(x => x.Expression);
-                foreach (var expressionSyntax in expressions)
+                var attributeArguments = argumentList.ChildNodes().OfType<AttributeArgumentSyntax>();
+                foreach (var attributeArgument in attributeArguments)
                 {
+                    var expressionSyntax = attributeArgument.Expression;
                     var expression = expressionSyntax.ToString();
+                    var nameEqualsExists = attributeArgument.ChildNodes().OfType<NameEqualsSyntax>().Any();
+                    var longNameEqualsExists = attributeArgument.ChildNodes().OfType<NameEqualsSyntax>().Any(x => x.Name.ToString() == "LongName");
+                    var mayBeLongName = !nameEqualsExists || longNameEqualsExists;
                     if (expression != null
                         && expression.StartsWith("\"", StringComparison.OrdinalIgnoreCase)
-                        && expression.EndsWith("\"", StringComparison.OrdinalIgnoreCase))
+                        && expression.EndsWith("\"", StringComparison.OrdinalIgnoreCase)
+                        && mayBeLongName)
                     {
                         var value = expression.Substring(1, expression.Length - 2);
                         if (value.Length >= 2)

src/dotnetCampus.CommandLine/CommandLine.cs

@@ -271,7 +271,7 @@ private static string[] ConvertUrlToArgs(string url)
             if (url != null)
             {
                 url = HttpUtility.UrlDecode(url);
-                var start = url.IndexOf('?');
+                var start = url.IndexOf('?', StringComparison.OrdinalIgnoreCase);
                 if (start >= 0 && url != null)
                 {
                     var arguments = url.Substring(start + 1);

src/dotnetCampus.CommandLine/CommandLineHandlers.cs

@@ -1,4 +1,6 @@
-using System;
+#pragma warning disable CA1303 // 请不要将文本作为本地化参数传递
+
+using System;
 using System.Diagnostics.Contracts;
 using System.Threading.Tasks;
 

src/dotnetCampus.CommandLine/Compatibility/NET45Compatibility.cs

@@ -0,0 +1,13 @@
+#if NETCOREAPP3_0 || NETCOREAPP3_1 || NETCOREAPP5_0 || NET5_0 || NET6_0
+#else
+namespace System
+{
+    internal static class NET45Compatibility
+    {
+        public static int IndexOf(this string @string, char value, StringComparison stringComparison)
+        {
+            return @string.IndexOf(value.ToString(), stringComparison);
+        }
+    }
+}
+#endif

src/dotnetCampus.CommandLine/Core/SingleOptimizedList.cs

@@ -19,7 +19,7 @@ internal class SingleOptimizedList<T> : IReadOnlyList<T>
         private List<T>? _restValues;
 
         /// <summary>
-        /// 创建带有一个值的 <see cref="SingleOptimizedList"/> 的实例。
+        /// 创建带有一个值的 <see cref="SingleOptimizedList{T}"/> 的实例。
         /// </summary>
         /// <param name="firstValue"></param>
         public SingleOptimizedList(T firstValue)

src/dotnetCampus.CommandLine/Parsers/ImmutableRuntimeOptionParser.cs

@@ -1,4 +1,6 @@
-using System;
+#pragma warning disable CA1303 // 请不要将文本作为本地化参数传递
+
+using System;
 using System.Collections.Generic;
 using System.Linq;
 using System.Reflection;
@@ -39,7 +41,7 @@ public ImmutableRuntimeOptionParser(string? verb, IReadOnlyList<PropertyInfo> at
                         _shortNameDictionary[attribute.ShortName.Value] = propertyInfo;
                     }
 
-                    if (string.IsNullOrWhiteSpace(attribute.LongName))
+                    if (attribute.LongName is null || string.IsNullOrWhiteSpace(attribute.LongName))
                     {
                         _longNameDictionary[propertyInfo.Name] = propertyInfo;
                     }

src/dotnetCampus.CommandLine/Parsers/RuntimeCommandLineOptionParser.cs

@@ -1,4 +1,6 @@
-using System;
+#pragma warning disable CA1303 // 请不要将文本作为本地化参数传递
+
+using System;
 using System.Collections.Generic;
 using System.Linq;
 using System.Reflection;