Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle Next-warnings #412

Closed
FluidSense opened this issue Sep 13, 2020 · 4 comments
Closed

Handle Next-warnings #412

FluidSense opened this issue Sep 13, 2020 · 4 comments
Labels
Type: Bug Something isn't working

Comments

@FluidSense
Copy link
Contributor

FluidSense commented Sep 13, 2020 •
edited by aslakhol
Loading

Currently, we are prompted with 3 warnings on setup.

1. FrontPage returned an empty object from getInitialProps. This de-optimizes and prevents automatic static optimization. https://err.sh/vercel/next.js/empty-object-getInitialProps
2. Please do not use @import CSS syntax in createGlobalStyle at this time, as the CSSOM APIs we use in production do not handle it well. Instead, we recommend using a library such as react-helmet to inject a typical meta tag to the stylesheet, or simply embedding it manually in your index.html section for a simpler app.
3. Warning: viewport meta tags should not be used in _document.js's . https://err.sh/next.js/no-document-viewport-meta
@FluidSense FluidSense added the Type: Bug Something isn't working label Sep 13, 2020
@FluidSense FluidSense mentioned this issue Sep 23, 2020
Open
@FluidSense
Copy link
Contributor Author

Number 2 could originate from '@dotkomonline/design-system'

@aslakhol
Copy link
Member

aslakhol commented Oct 9, 2020

2 is resolved by #502 and dotkom/design-system#190

  1. is resolved by Upgrade ds and include fonts #502

@aslakhol aslakhol mentioned this issue Oct 9, 2020
Merged
@aslakhol
Copy link
Member

aslakhol commented Oct 9, 2020

  1. is moved to Handle Next.js warning #503

@FluidSense
Copy link
Contributor Author

Resolved in favor of #503

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@aslakhol @FluidSense