Skip to content

Commit 1893633

Browse files
authored
Develop (#2)
* refactoring
1 parent 4933808 commit 1893633

File tree

6 files changed

+77
-46
lines changed

6 files changed

+77
-46
lines changed

CHANGELOG.md

Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,15 @@
1+
## 0.1.0 - 2017-03-09
2+
3+
Initial tagged release
4+
5+
### Added
6+
* Everything
7+
8+
### Deprecated
9+
* Nothing
10+
11+
### Removed
12+
* Nothing
13+
14+
### Fixed
15+
* Nothing

README.md

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -16,38 +16,38 @@ Next, make sure you merge the `ConfigProvider` to your application's configurati
1616

1717
In any controller, you can access the plugin by calling
1818
```php
19-
$this->flashMessenger()->...
19+
$this->messenger()->...
2020
```
2121

2222
The methods defined by this plugin are
2323
```php
24-
$this->flashMessenger()->addMessage($namespace, $value);
24+
$this->messenger()->addMessage($namespace, $value);
2525
```
2626
Adds a session message to at the requested namespace
2727

2828
```php
29-
$this->flashMessenger()->addData($key, $data);
29+
$this->messenger()->addData($key, $data);
3030
```
3131
Almost the same as the addMessage method, but named differently in order to reserve this function for adding general session data.
3232

3333
There are also some shortcuts to the addMessage method which are using predefined namespaces
3434
```php
35-
$this->flashMessenger()->addError($error);
35+
$this->messenger()->addError($error);
3636

37-
$this->flashMessenger()->addWarning($message);
37+
$this->messenger()->addWarning($message);
3838

39-
$this->flashMessenger()->addInfo($message);
39+
$this->messenger()->addInfo($message);
4040

41-
$this->flashMessenger()->addSuccess($message);
41+
$this->messenger()->addSuccess($message);
4242
```
4343

4444
Also, the getter methods
4545
```php
46-
$this->flashMessenger()->getMessages($namespace = null);
46+
$this->messenger()->getMessages($namespace = null);
4747
```
4848
Gets all messages under a namespace, or if namespace is not specified it will return all namespaces with all messages
4949

5050
```php
51-
$this->flashMessenger()->getData($key);
51+
$this->messenger()->getData($key);
5252
```
53-
Gets the data stored at the specified key
53+
Gets the data stored at the specified key

composer.json

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
{
22
"name": "dotkernel/dot-controller-plugin-flashmessenger",
33
"type": "library",
4-
"description": "Flashmessenger DK controller plugin",
4+
"description": "DotKernel flash messenger controller plugin",
55
"license": "MIT",
66
"authors": [
77
{
@@ -10,15 +10,15 @@
1010
}
1111
],
1212
"require": {
13-
"php": "^5.6 || ^7.0",
13+
"php": "^7.1",
1414
"container-interop/container-interop": "^1.1",
15-
"dotkernel/dot-controller": "0.6.x-dev"
15+
16+
"dotkernel/dot-controller": "~0.1",
17+
"dotkernel/dot-flashmessenger": "~0.1"
1618
},
1719
"require-dev": {
1820
"phpunit/phpunit": "^4.8",
19-
"squizlabs/php_codesniffer": "^2.3",
20-
21-
"dotkernel/dot-flashmessenger": "0.6.x-dev"
21+
"squizlabs/php_codesniffer": "^2.3"
2222
},
2323
"autoload": {
2424
"psr-4": {
@@ -32,7 +32,7 @@
3232
},
3333
"extra": {
3434
"branch-alias": {
35-
"dev-master": "0.6-dev"
35+
"dev-master": "0.2-dev"
3636
}
3737
}
3838
}

src/ConfigProvider.php

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,8 @@
77
* Time: 6:49 PM
88
*/
99

10+
declare(strict_types = 1);
11+
1012
namespace Dot\Controller\Plugin\FlashMessenger;
1113

1214
use Dot\Controller\Plugin\FlashMessenger\Factory\FlashMessengerPluginFactory;
@@ -20,13 +22,13 @@ class ConfigProvider
2022
/**
2123
* @return array
2224
*/
23-
public function __invoke()
25+
public function __invoke(): array
2426
{
2527
return [
2628
'dot_controller' => [
2729
'plugin_manager' => [
2830
'factories' => [
29-
'flashMessenger' => FlashMessengerPluginFactory::class,
31+
'messenger' => FlashMessengerPluginFactory::class,
3032
],
3133
],
3234
],

src/Factory/FlashMessengerPluginFactory.php

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,8 @@
77
* Time: 6:50 PM
88
*/
99

10+
declare(strict_types = 1);
11+
1012
namespace Dot\Controller\Plugin\FlashMessenger\Factory;
1113

1214
use Dot\Controller\Plugin\FlashMessenger\FlashMessengerPlugin;

src/FlashMessengerPlugin.php

Lines changed: 39 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,8 @@
77
* Time: 6:49 PM
88
*/
99

10+
declare(strict_types = 1);
11+
1012
namespace Dot\Controller\Plugin\FlashMessenger;
1113

1214
use Dot\Controller\Plugin\PluginInterface;
@@ -31,70 +33,80 @@ public function __construct(FlashMessengerInterface $flashMessenger)
3133
}
3234

3335
/**
34-
* @param string $namespace
36+
* @param string $type
37+
* @param string $channel
3538
* @param mixed $value
3639
*/
37-
public function addMessage($namespace, $value)
40+
public function addMessage(string $type, $value, string $channel = FlashMessengerInterface::DEFAULT_CHANNEL)
3841
{
39-
$this->flashMessenger->addMessage($namespace, $value);
42+
$this->flashMessenger->addMessage($type, $value, $channel);
4043
}
4144

4245
/**
43-
* @param $key
44-
* @param $value
46+
* @param string $key
47+
* @param string $channel
48+
* @param mixed $value
4549
*/
46-
public function addData($key, $value)
50+
public function addData(string $key, $value, string $channel = FlashMessengerInterface::DEFAULT_CHANNEL)
4751
{
48-
$this->flashMessenger->addData($key, $value);
52+
$this->flashMessenger->addData($key, $value, $channel);
4953
}
5054

5155
/**
52-
* @param $error
56+
* @param mixed $error
57+
* @param string $channel
5358
*/
54-
public function addError($error)
59+
public function addError($error, string $channel = FlashMessengerInterface::DEFAULT_CHANNEL)
5560
{
56-
$this->flashMessenger->addError($error);
61+
$this->flashMessenger->addError($error, $channel);
5762
}
5863

5964
/**
60-
* @param $message
65+
* @param mixed $message
66+
* @param string $channel
6167
*/
62-
public function addWarning($message)
68+
public function addWarning($message, string $channel = FlashMessengerInterface::DEFAULT_CHANNEL)
6369
{
64-
$this->flashMessenger->addWarning($message);
70+
$this->flashMessenger->addWarning($message, $channel);
6571
}
6672

6773
/**
68-
* @param $message
74+
* @param mixed $message
75+
* @param string $channel
6976
*/
70-
public function addInfo($message)
77+
public function addInfo($message, string $channel = FlashMessengerInterface::DEFAULT_CHANNEL)
7178
{
72-
$this->flashMessenger->addInfo($message);
79+
$this->flashMessenger->addInfo($message, $channel);
7380
}
7481

7582
/**
76-
* @param $message
83+
* @param mixed $message
84+
* @param string $channel
7785
*/
78-
public function addSuccess($message)
86+
public function addSuccess($message, string $channel = FlashMessengerInterface::DEFAULT_CHANNEL)
7987
{
80-
$this->flashMessenger->addSuccess($message);
88+
$this->flashMessenger->addSuccess($message, $channel);
8189
}
8290

8391
/**
84-
* @param $namespace
85-
* @return array|null
92+
* @param string $type
93+
* @param string $channel
94+
* @return array
8695
*/
87-
public function getMessages($namespace = null)
88-
{
89-
return $this->flashMessenger->getMessages($namespace);
96+
public function getMessages(
97+
string $type = null,
98+
string $channel = FlashMessengerInterface::DEFAULT_CHANNEL
99+
): array {
100+
return $this->flashMessenger->getMessages($type, $channel);
90101
}
91102

92103
/**
93-
* @param $key
104+
* @param string $key
105+
* @param string $channel
94106
* @return mixed
95107
*/
96-
public function getData($key)
108+
public function getData(string $key, string $channel = FlashMessengerInterface::DEFAULT_CHANNEL)
97109
{
98-
return $this->flashMessenger->getData($key);
110+
return $this->flashMessenger->getData($key, $channel);
99111
}
100112
}

0 commit comments

Comments
 (0)