Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test images from the paper. #1

Open
singmile opened this issue Apr 2, 2020 · 0 comments
Open

Test images from the paper. #1

singmile opened this issue Apr 2, 2020 · 0 comments

Comments

@singmile
Copy link

singmile commented Apr 2, 2020

Hello Thien Do-Tieu, thanks for your code, very impressive!
But when I try to test the images from the paper, the results are quite strange. As shown below:

Left: input   Right: output (before crop)
5 out4
test9out9
I'm not sure if you have found this and do you know how to solve it? Thanks!

Btw, personally I think line136 of rectification.py should be:
w = (u1[0] / u1[2] - v1[0] / v1[2]) ** 2 + (u1[1] / u1[2] - v1[1] / v1[2]) ** 2
(just based on my personal understanding of Equations 14 and 15 in the paper. so forgive me if I misunderstood it.)
But after I changing this line, it almost have no influence to the results.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant