Skip to content

Commit d3d9a2a

Browse files
committed
Fix Source vs Types.DocumentFile usage for type correctness
1 parent d2d647b commit d3d9a2a

4 files changed

Lines changed: 12 additions & 7 deletions

File tree

packages/graphql-codegen-cli/src/load.ts

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
import { extname, join } from 'path';
22
import { GraphQLError, GraphQLSchema } from 'graphql';
3+
import type { Source } from 'graphql-config';
34
import { Types } from '@graphql-codegen/plugin-helpers';
45
import { ApolloEngineLoader } from '@graphql-tools/apollo-engine-loader';
56
import { CodeFileLoader } from '@graphql-tools/code-file-loader';
@@ -68,8 +69,8 @@ export async function loadSchema(
6869

6970
export async function loadDocuments(
7071
documentPointers: UnnormalizedTypeDefPointer | UnnormalizedTypeDefPointer[],
71-
config: Types.Config,
72-
): Promise<Types.DocumentFile[]> {
72+
config: Types.Config
73+
): Promise<Source[]> {
7374
const loaders = [
7475
new CodeFileLoader({
7576
pluckConfig: {

packages/plugins/other/visitor-plugin-common/src/optimize-operations.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@ export function optimizeOperations(
1414
);
1515

1616
return newDocuments.map((document, index) => ({
17+
...documents[index],
1718
location: documents[index]?.location || 'optimized by relay',
1819
document,
1920
}));

packages/plugins/typescript/gql-tag-operations/src/index.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,15 @@
11
import { FragmentDefinitionNode, OperationDefinitionNode } from 'graphql';
22
import { normalizeImportExtension, PluginFunction } from '@graphql-codegen/plugin-helpers';
33
import { DocumentMode } from '@graphql-codegen/visitor-plugin-common';
4-
import { Source } from '@graphql-tools/utils';
4+
import type { Types } from '@graphql-codegen/plugin-helpers';
55

66
export type OperationOrFragment = {
77
initialName: string;
88
definition: OperationDefinitionNode | FragmentDefinitionNode;
99
};
1010

1111
export type SourceWithOperations = {
12-
source: Source;
12+
source: Types.DocumentFile;
1313
operations: Array<OperationOrFragment>;
1414
};
1515

packages/presets/client/src/process-sources.ts

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,13 @@
11
import { FragmentDefinitionNode, OperationDefinitionNode } from 'graphql';
22
import { OperationOrFragment, SourceWithOperations } from '@graphql-codegen/gql-tag-operations';
3-
import { Source } from '@graphql-tools/utils';
3+
import type { Types } from '@graphql-codegen/plugin-helpers';
44

55
export type BuildNameFunction = (type: OperationDefinitionNode | FragmentDefinitionNode) => string;
66

7-
export function processSources(sources: Array<Source>, buildName: BuildNameFunction) {
7+
export function processSources(
8+
sources: Array<Types.DocumentFile>,
9+
buildName: BuildNameFunction
10+
): Array<SourceWithOperations> {
811
const sourcesWithOperations: Array<SourceWithOperations> = [];
912

1013
for (const originalSource of sources) {
@@ -86,7 +89,7 @@ export function processSources(sources: Array<Source>, buildName: BuildNameFunct
8689
*
8790
* @param source
8891
*/
89-
function fixLinebreaks(source: Source) {
92+
function fixLinebreaks(source: Types.DocumentFile) {
9093
const fixedSource = { ...source };
9194

9295
fixedSource.rawSDL = source.rawSDL.replace(/\r\n/g, '\n');

0 commit comments

Comments
 (0)