Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc fix for an extra apostrophe in the code example for additionalDI (apollo-angular config.) #693

Open
salticus opened this issue Apr 24, 2024 · 0 comments

Comments

@salticus
Copy link

Which packages are impacted by your issue?

@graphql-codegen/typescript-apollo-angular

Describe the bug

The line currently reads

additionalDI: ['testService: TestService', 'testService1': TestService1']

Based on the type of string[] for additionalDI, I believe that the apostrophe after testService1 should be removed.

Your Example Website or App

https://the-guild.dev/graphql/codegen/plugins/typescript/typescript-apollo-angular#usage-examples-9

Steps to Reproduce the Bug or Issue

  1. Go to https://the-guild.dev/graphql/codegen/plugins/typescript/typescript-apollo-angular#usage-examples-9
  2. Observe the code example for additionalDI

Expected behavior

As a user, I expected to see valid syntax, but I see something that produces a syntax error.

Screenshots or Videos

No response

Platform

Web

Codegen Config File

No response

Additional context

The link "Edit this page on Github" is still leading to the original repository: https://github.com/dotansimha/graphql-code-generator, rather than this one. A search of the git log showed the code had been moved here.

The list of possible options on this repository does not include documentation fixes, so I'm submitting this as a "bug."

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant