system unusable in case of not approved xcode license

[markfink]

I like your scripts. dots is very easy to use and for me it provides an efficient way to setup my machine. Thank you for it!

However my first experience was not as smooth as it could be. I installed xcode to prepare for this. After that I ran dots and it complained a lot that it could not find brew. Unfortunately it did not stop and left my machine in a unusable state. Only when I attempted to manually install homebrew it told me to approve the xcode license. This is probably a simple improvement but could save a lot of pain for new mac users like me.

Mark

[donnemartin]

Hi @markfink thanks for the feedback and for reporting this issue.

I think it's odd that it could not find brew, before brew is used it should be installed with this section of brew.sh.

Only when I attempted to manually install homebrew it told me to approve the xcode license

Hmm perhaps you mean osxprep.sh now requires you to have homebrew installed?

Which OS version are you running?

[markfink]

@donnemartin hmmm, I meant that it was not possible to install brew because I did not approve the xcode license... That was definitely my fault. I just thought that it would be better if your script could just stop if brew is not available. I mean it is not really helpful to change the configuration if the binaries are missing. For example I could not even open a terminal after I ran ./.dots <...>. I think this was because the bash binary was missing and dots changed the login shell to bash anyways.

I run El Capitan 10.11.6

Anyway, I found the workaround and everything works fine now.

[donnemartin]

Ah I see, thanks for clearing that up!

I'll see if there's a good way to check for whether the Xcode license has been accepted and where to best put it.

Perhaps a note in the README.