Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Importing unused parts of gl-matrix #210

Closed
donmccurdy opened this issue Apr 2, 2021 · 1 comment
Closed

Importing unused parts of gl-matrix #210

donmccurdy opened this issue Apr 2, 2021 · 1 comment
Labels
bug Something isn't working package:core
Milestone

Comments

@donmccurdy
Copy link
Owner

1672dfe contained a change to how gl-matrix is updated, because its (external) type definitions do not allow the earlier syntax:

// before
import { determinant, getRotation } from 'gl-matrix/mat4';
import { length } from 'gl-matrix/vec3';

// after
import { mat4 as glMat4, vec3 as glVec3 } from 'gl-matrix';

Unfortunately this means we'll be importing more of the library, and probably increasing bundle size. Should try to see if the type definitions can be fixed, or work around this another way.

@donmccurdy donmccurdy added bug Something isn't working package:core labels Apr 2, 2021
@donmccurdy donmccurdy added this to the v0.9 milestone Apr 2, 2021
@donmccurdy donmccurdy changed the title Importing too much from gl-matrix Importing unused parts of gl-matrix Apr 2, 2021
@donmccurdy
Copy link
Owner Author

Fixed in f1caf79. Just reverting the changes for now, TBD fix for type declarations. toji/gl-matrix#423.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working package:core
Projects
None yet
Development

No branches or pull requests

1 participant