Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

staticcheck: extend SA5005 for runtime.AddCleanup #1622

Open
dominikh opened this issue Dec 4, 2024 · 0 comments
Open

staticcheck: extend SA5005 for runtime.AddCleanup #1622

dominikh opened this issue Dec 4, 2024 · 0 comments
Labels
enhancement

Comments

@dominikh
Copy link
Owner

dominikh commented Dec 4, 2024

Go 1.24 adds runtime.AddCleanup, a better alternative to SetFinalizer. Just like SetFinalizer, the callback shouldn't reference the finalized object. Additionally, AddCleanup mustn't be called with arg == ptr.

We might also consider flagging usage of AddCleanup and SetFinalizer on zero size objects.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dominikh