Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apparent gap in get.shifts when include_open + unpublished. #16

Open
cjaoude opened this issue Feb 27, 2019 · 0 comments
Open

Apparent gap in get.shifts when include_open + unpublished. #16

cjaoude opened this issue Feb 27, 2019 · 0 comments

Comments

@cjaoude
Copy link

cjaoude commented Feb 27, 2019

Hi, so when requesting Open Shifts and Unpublished shifts, the api response is missing Open+Unpublished shifts.

// get.shifts...doesn't return open-unpublished shifts
'include_open' => true,
'unpublished' => true,

instead it works correctly with all_open + unpublished.

'include_allopen' => true,
'unpublished' => true,

This is not readily apparent. The documentation should be improved, but also include_open should included unpublished shifts, since we may not want the 'conflict' shifts that come with include_allopen.

just fyi, thanks

@cjaoude cjaoude changed the title Apparent gap in get.shifts when open shifts + unpublished. Apparent gap in get.shifts when include_allopen + unpublished. Feb 27, 2019
@cjaoude cjaoude changed the title Apparent gap in get.shifts when include_allopen + unpublished. Apparent gap in get.shifts when include_open + unpublished. Feb 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant