Fix perltidy (#4)

* clean up verbage

* we vendor bats and need perltidy

* lint

* improve CI flow

Author: docwhat

.github/workflows/ci.yaml

@@ -1,5 +1,6 @@
 # GitHub Action to run all my CI tasks.
-name: Continuous Integration
+name: Run Required Checks
+run-name: PR Checks for ${{ github.ref_name }}
 
 on:
   pull_request:
@@ -10,25 +11,31 @@ on:
 permissions: read-all
 
 jobs:
-  ci:
+  lint:
+    name: Lint Check
     runs-on: ubuntu-latest
     steps:
+      - name: Install perltidy
+        run: sudo apt-get update && sudo apt-get install -y perltidy
+
       - name: Checkout
         uses: actions/checkout@v4
 
-      - name: Setup Bats and bats libs
-        uses: bats-core/bats-action@2.0.0
-        with:
-          detik-install: false
-          support-install: false
-          assert-install: false
-          file-install: false
-
       - name: Bootstrap Check
         run: ./script/bootstrap
 
       - name: Lint Check
         run: ./script/lint
 
+  unit_tests:
+    name: Unit Tests
+    runs-on: ubuntu-latest
+    steps:
+      - name: Checkout
+        uses: actions/checkout@v4
+
+      - name: Bootstrap Check
+        run: ./script/bootstrap
+
       - name: Tests
         run: ./script/test

script/bootstrap

@@ -26,13 +26,15 @@ has() {
 }
 
 success() {
+  printf "%s %s%s%s\n" \
+    "${checkmark}" "${green}${bold}" "$1" "${reset}"
   success=$((success + 1))
-  printf "%s %s%s%s\n" "${checkmark}" "${green}${bold}" "$1" "${reset}"
 }
 
 failure() {
+  printf "%s %s%s%s\n" \
+    "${crossmark}" "${red}${bold}" "$1" "${reset}"
   failure=$((failure + 1))
-  printf "%s %s%s%s\n" "${crossmark}" "${red}${bold}" "$1" "${reset}"
 }
 
 instructions() {
@@ -98,7 +100,7 @@ printf '\nsuccesss: %s%d%s  failures: %s%d%s\n' "${green}" "${success}" "${reset
 
 if ((failure > 0)); then
   printf '\n%sBootstrap failed!%s\n' "${red}" "${reset}"
-  printf '%sPlease resolve the above issues.%s\n' "${yellow}" "${reset}"
+  instructions "  Please fix the issues above and run this script again."
   exit 1
 else
   printf '\n%sSuccess! 🎉%s\n' "${green}" "${reset}"

tests/test_helper/pseudo-tty.py

@@ -1,7 +1,8 @@
 #!/usr/bin/env python3
 
-import os, pty, sys
-
+import os
+import pty
+import sys
 
 sys.exit(
     os.waitstatus_to_exitcode(pty.spawn(sys.argv[1:], lambda fd: os.read(fd, 1024)))