Skip to content
This repository has been archived by the owner on Aug 2, 2020. It is now read-only.

Make sure that all the changes since the last release are associated to the milestone #37

Closed
morozov opened this issue Jan 5, 2020 · 2 comments
Assignees
Labels
duplicate This issue or pull request already exists enhancement New feature or request

Comments

@morozov
Copy link
Member

morozov commented Jan 5, 2020

Right now, for a given pull request, the target branch and the associated milestone are totally independent. It allows for a situation when some changes are released as part of the changes in the branch being tagged but are not listed in the release note. It happens every once in a while.

High-level, the logic is the following:

  1. Take all merge commits since the last release.
  2. Associate them with pull requests on GitHub and the corresponding issues (via the Fixes and Closes references).
  3. If there's a discrepancy, report a problem and halt.
  4. Additionally, if some changes need to be excluded from the notes explicitly, there may be a label for that.
@morozov
Copy link
Member Author

morozov commented Jan 13, 2020

For the reference: doctrine/dbal#3790 (comment) (happened in a manually managed release).

@Ocramius
Copy link
Member

Ocramius commented Aug 2, 2020

Moved to laminas/automatic-releases#27

@Ocramius Ocramius closed this as completed Aug 2, 2020
@Ocramius Ocramius added duplicate This issue or pull request already exists enhancement New feature or request labels Aug 2, 2020
@Ocramius Ocramius self-assigned this Aug 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
duplicate This issue or pull request already exists enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants