Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename repository #255

Open
bakura10 opened this issue May 20, 2013 · 9 comments
Open

Rename repository #255

bakura10 opened this issue May 20, 2013 · 9 comments

Comments

@bakura10
Copy link
Member

Hi @Ocramius ,

For homogeneity purpose with how composer name packages, I think it would be a good idea to rename the GitHub project from "DoctrineModule" to "doctrine-module". I tried it with my own projects, it's absolutely painless, it breaks nothing (even the old URL is redirected to the new one). It just provides more homogeneity and it seems like some projects like Doctrine adopte this (as well as zf itself).

(I'm not going to raise in issue but the same applies for DoctrineModuleORMModule, DoctrineModuleMongo...)

EDIT : in fact, the composer package canonical also needs to be updated on Packagist.

@Ocramius
Copy link
Member

@bakura10 that's a perfectly fine request by me - we're already doing this for ORM, so let's wait and see how that turns out.

I don't see anything against it, but it's not a priority now

@bakura10
Copy link
Member Author

Nice. In fact it's pretty easy. Basically the only pain is that people will just need to rename their remote branches in git (I think).

@Ocramius
Copy link
Member

@bakura10 I think github handles that, no?

@bakura10
Copy link
Member Author

Maybe! AT least the links to the repo still work.

@superdweebie
Copy link
Contributor

+1

@bakura10
Copy link
Member Author

For information, here are the steps I needed to do to make it work correctly:

  1. Remove the module from modules.zendframework.com
  2. Rename the repository on GitHub.
  3. Optionally change the name on composer.json here (https://github.com/doctrine/DoctrineModule/blob/master/composer.json#L6) but that's not needed here as it does not point to GitHub.
  4. Log into Packagist and manually update the link.
  5. Readd the module to modules.zendframework.com

All the forks will still point to the new name without any breaks.

@danizord
Copy link
Contributor

The only problem will be broken links =/

@bakura10
Copy link
Member Author

No, github does redirections.

Envoyé de mon iPhone

Le 21 mai 2013 à 02:46, Daniel Gimenes [email protected] a écrit :

The only problem will be broken links =/


Reply to this email directly or view it on GitHub.

@danizord
Copy link
Contributor

So looks perfect (:

gencer pushed a commit to gencer/DoctrineModule that referenced this issue Apr 11, 2014
HOTFIX - DoctrineDataCollector backward compatibility
@driehle driehle removed this from the 1.0.0 milestone Oct 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants