Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync PR builds not occurring during CI on AppVeyor #106

Open
atifaziz opened this issue Aug 16, 2021 · 0 comments
Open

Sync PR builds not occurring during CI on AppVeyor #106

atifaziz opened this issue Aug 16, 2021 · 0 comments

Comments

@atifaziz
Copy link
Collaborator

atifaziz commented Aug 16, 2021

Unfortunately, once PR #104 was merged, the build failed on master due to compilation errors:

C:\projects\docopt-net\src\DocoptNet\Docopt.cs(174,88): error CS1503: Argument 2: cannot convert from 'DocoptNet.Value' to 'DocoptNet.ValueObject' [C:\projects\docopt-net\src\DocoptNet\DocoptNet.csproj]
C:\projects\docopt-net\src\DocoptNet\Docopt.cs(175,123): error CS1503: Argument 4: cannot convert from 'DocoptNet.Value' to 'DocoptNet.ValueObject' [C:\projects\docopt-net\src\DocoptNet\DocoptNet.csproj]
C:\projects\docopt-net\src\DocoptNet\Docopt.cs(174,88): error CS1503: Argument 2: cannot convert from 'DocoptNet.Value' to 'DocoptNet.ValueObject' [C:\projects\docopt-net\src\DocoptNet\DocoptNet.csproj]
C:\projects\docopt-net\src\DocoptNet\Docopt.cs(175,123): error CS1503: Argument 4: cannot convert from 'DocoptNet.Value' to 'DocoptNet.ValueObject' [C:\projects\docopt-net\src\DocoptNet\DocoptNet.csproj]
C:\projects\docopt-net\src\DocoptNet\Docopt.cs(174,88): error CS1503: Argument 2: cannot convert from 'DocoptNet.Value' to 'DocoptNet.ValueObject' [C:\projects\docopt-net\src\DocoptNet\DocoptNet.csproj]
C:\projects\docopt-net\src\DocoptNet\Docopt.cs(175,123): error CS1503: Argument 4: cannot convert from 'DocoptNet.Value' to 'DocoptNet.ValueObject' [C:\projects\docopt-net\src\DocoptNet\DocoptNet.csproj]
C:\projects\docopt-net\src\DocoptNet\Docopt.cs(182,20): error CS8619: Nullability of reference types in value of type 'TSource[]' doesn't match target type 'IEnumerable<T>'. [C:\projects\docopt-net\src\DocoptNet\DocoptNet.csproj]
C:\projects\docopt-net\src\DocoptNet\Docopt.cs(174,88): error CS1503: Argument 2: cannot convert from 'DocoptNet.Value' to 'DocoptNet.ValueObject' [C:\projects\docopt-net\src\DocoptNet.Playground\DocoptNet.Playground.csproj]
C:\projects\docopt-net\src\DocoptNet\Docopt.cs(175,123): error CS1503: Argument 4: cannot convert from 'DocoptNet.Value' to 'DocoptNet.ValueObject' [C:\projects\docopt-net\src\DocoptNet.Playground\DocoptNet.Playground.csproj]

From what I understand, AppVeyor builds are triggered on:

  • push to branch
  • merge PR to branch
  • open PR
  • sync PR (when you do push to branch with open PR)

It seems that PR #105 was merged into master before, but did not trigger a build for PR #104 that was also targeting the same branch (sync PR case above). Had that happened then the build errors would have been caught before breaking master.

/cc @voieducode


📎 log.txt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant