build(deps): upgrade to compose-go v1.18.3 #10947
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://github.com/compose-spec/compose-go/releases/tag/v1.18.3 Signed-off-by: Milas Bowman <[email protected]>
milas
requested review from
nicksieger,
ndeloof,
StefanScherer,
ulyssessouza,
glours and
laurazard
and removed request for
a team
milas
commented
Aug 29, 2023
| @@ -262,7 +262,7 @@ func (o *ProjectOptions) toProjectOptions(po ...cli.ProjectOptionsFn) (*cli.Proj | |||
| cli.WithDotEnv, | |||
| cli.WithConfigFileEnv, | |||
| cli.WithDefaultConfigPath, | |||
| cli.WithProfiles(o.Profiles), | |||
| cli.WithDefaultProfiles(o.Profiles...), | |||
There was a problem hiding this comment.
See compose-spec/compose-go#446 - it was reading COMPOSE_PROFILES in the load, it's now done via this option up-front for consistency & correct layering
ndeloof
approved these changes
Aug 29, 2023
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #10947 +/- ##
==========================================
- Coverage 58.28% 58.19% -0.10%
==========================================
Files 123 123
Lines 10864 10864
==========================================
- Hits 6332 6322 -10
- Misses 3912 3920 +8
- Partials 620 622 +2
☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Bump to [email protected]
Related issue
Fixes:
(not mandatory) A picture of a cute animal, if possible in relation to what you did
