solver: fix reading secrets from any session #5833
Open
+11
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current logic was incorrect in some places so that if first session randomly chosen by `Any()` returned NotFound then other sessions were not attempted. For the main use case of mounting secrets as files the logic was correct, but it was incorrect for example for the case of adding secrets as environment variables. Signed-off-by: Tonis Tiigi <[email protected]>
tonistiigi
force-pushed
the
secret-env-fix
branch
from
71cee2f to
91b55e8
Compare
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current logic was incorrect in some places so that if first session randomly chosen by
Any()returned NotFound then other sessions were not attempted.For the main use case of mounting secrets as files the logic was correct, but it was incorrect for example for the case of adding secrets as environment variables.
fix docker/buildx#3056